Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the discrepancy in the mask type for _mm_shuffle_ps #75009

Merged
merged 1 commit into from
Aug 2, 2020

Conversation

georgio
Copy link
Contributor

@georgio georgio commented Aug 1, 2020

This Pull Request updates the stdarch submodule in order to resolve #62490

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @kennytm (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 1, 2020
@kennytm
Copy link
Member

kennytm commented Aug 1, 2020

Please checkout the submodule at 78891cd instead of the current d6822f9c433bd70f786b157f17beaf64ee28d83a.

r=me afterwards.

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 1, 2020
@georgio
Copy link
Contributor Author

georgio commented Aug 1, 2020

@kennytm done :-)

@kennytm
Copy link
Member

kennytm commented Aug 2, 2020

🤔 could you do a clean rebase? a lot of irrelevant diff is brought in.

git fetch origin master
git checkout master
git reset --hard origin/master
cd library/stdarch
git checkout d6822f9c433bd70f786b157f17beaf64ee28d83a
cd -
git add library/stdarch
git commit
git push georgio master --force-with-lease

@georgio
Copy link
Contributor Author

georgio commented Aug 2, 2020

Sorry about that, these commits happened by mistake (my first time contributing).
Thanks for the instructions to fix it! I hope it works now.

@kennytm
Copy link
Member

kennytm commented Aug 2, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Aug 2, 2020

📌 Commit 1e2ce28 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 2, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 2, 2020
…arth

Rollup of 5 pull requests

Successful merges:

 - rust-lang#74980 (pprust: adjust mixed comment printing and add regression test for rust-lang#74745)
 - rust-lang#75009 (Document the discrepancy in the mask type for _mm_shuffle_ps)
 - rust-lang#75031 (Do not trigger `unused_{braces,parens}` lints with `yield`)
 - rust-lang#75059 (fix typos)
 - rust-lang#75064 (compiletest: Support ignoring tests requiring missing LLVM components)

Failed merges:

r? @ghost
@bors bors merged commit 1b350ec into rust-lang:master Aug 2, 2020
@jethrogb
Copy link
Contributor

jethrogb commented Aug 3, 2020

@kennytm Please don't approve changes that make submodules point to commits that are not part of the target repository's submodule branch.

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 3, 2020
Fix broken git commit in stdarch

Follow-up on rust-lang#75009, point to the real master commit.
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core::arch::x86_64::_mm_shuffle_ps input doesn't match official docs
6 participants