Do not trigger unused_{braces,parens} lints with yield
#75031
Merged
+96
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
tesuji
reviewed
Aug 2, 2020
lcnr
reviewed
Aug 2, 2020
|
The duplicate errors on while are actually part of a bigger problem, the following should not warn: fn main() {
let mut a = Some(3);
while let Some(ref mut v) = {a} {
a.as_mut().map(|a| std::mem::swap(a, v));
}
}The way to fix this would be to pretty much copy what we are already doing for If you want to fix that as part of this PR, feel free, otherwise r=me @bors delegate+ |
|
✌️ @JohnTitor can now approve this pull request |
1 similar comment
|
✌️ @JohnTitor can now approve this pull request |
Ah, interesting! I didn't realize this case, yeah, we should fix then.
I'm going to r=you as-is since I think the fix is out of context of @bors r=lcnr |
|
📌 Commit 2e7ba78 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 2, 2020
…arth Rollup of 5 pull requests Successful merges: - rust-lang#74980 (pprust: adjust mixed comment printing and add regression test for rust-lang#74745) - rust-lang#75009 (Document the discrepancy in the mask type for _mm_shuffle_ps) - rust-lang#75031 (Do not trigger `unused_{braces,parens}` lints with `yield`) - rust-lang#75059 (fix typos) - rust-lang#75064 (compiletest: Support ignoring tests requiring missing LLVM components) Failed merges: r? @ghost
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Aug 3, 2020
…r=lcnr Do not trigger `unused_braces` for `while let` Follow-up for rust-lang#75031 r? @lcnr
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Aug 3, 2020
…r=lcnr Do not trigger `unused_braces` for `while let` Follow-up for rust-lang#75031 r? @lcnr
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Aug 3, 2020
…r=lcnr Do not trigger `unused_braces` for `while let` Follow-up for rust-lang#75031 r? @lcnr
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Aug 3, 2020
…r=lcnr Do not trigger `unused_braces` for `while let` Follow-up for rust-lang#75031 r? @lcnr
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Aug 4, 2020
…r=lcnr Do not trigger `unused_braces` for `while let` Follow-up for rust-lang#75031 r? @lcnr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74883
r? @lcnr