Use intra-doc links in `std::env`, `std::alloc` and `std::error` #75629

BoxyUwU · 2020-08-17T14:03:02Z

This is partial fixes for #75080.

rust-highfive · 2020-08-17T14:03:05Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

jyn514 · 2020-08-17T14:03:51Z

r? @jyn514

jyn514

Looks good after nits are fixed :)

library/std/src/env.rs

jyn514 · 2020-08-17T14:25:25Z

@bors r+ rollup

bors · 2020-08-17T14:25:26Z

📌 Commit e7a7279 has been approved by jyn514

library/std/src/env.rs

library/std/src/error.rs

@ghost

Rollup of 8 pull requests Successful merges: - rust-lang#75389 (attempt to improve span_label docs) - rust-lang#75392 (Add `as_uninit`-like methods to pointer types and unify documentation of `as_ref` methods) - rust-lang#75464 (Move to intra doc links for ascii.rs and panic.rs) - rust-lang#75578 (Allowing raw ptr dereference in const fn) - rust-lang#75613 (Add explanation for `&mut self` method call when expecting `-> Self`) - rust-lang#75626 (Clean up E0754 explanation) - rust-lang#75629 (Use intra-doc links in `std::env`, `std::alloc` and `std::error`) - rust-lang#75634 (Mark x86_64-linux-kernel as *) Failed merges: r? @ghost

@jyn514

Error use explicit intra-doc link and fix text Follow up of rust-lang#75629 r? @jyn514

@jyn514

Use `env::func()`, not 'the function env::func' in docs for std::env Follow up of rust-lang#75629 r? @jyn514

BoxyUwU added 3 commits August 17, 2020 14:42

Switch to intra-doc links for std/src/error.rs

509cad7

Switch to intra-doc links for std/src/env.rs

b6d2868

Switch to intra-doc links for std/src/alloc.rs

a2dfc3e

rust-highfive assigned sfackler Aug 17, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 17, 2020

rust-highfive assigned jyn514 and unassigned sfackler Aug 17, 2020

jyn514 reviewed Aug 17, 2020

View reviewed changes

library/std/src/env.rs Outdated Show resolved Hide resolved

library/std/src/env.rs Outdated Show resolved Hide resolved

library/std/src/env.rs Outdated Show resolved Hide resolved

library/std/src/env.rs Outdated Show resolved Hide resolved

Remove unnecessary links in env.rs

e7a7279

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2020