Uplift drop-bounds lint from clippy #75699

notriddle · 2020-08-19T10:32:59Z

Bounds on T: Drop do nothing, so they should warn.

rust-highfive · 2020-08-19T10:33:03Z

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

src/librustc_lint/traits.rs

library/core/src/ops/drop.rs

src/test/ui/drop-bounds/drop-bounds.rs

src/librustc_lint/traits.rs

petrochenkov · 2020-08-19T19:45:49Z

This looks reasonable to me.
Could you open an MCP for this? (Example: rust-lang/compiler-team#346)

src/test/ui/drop-bounds/drop-bounds.rs

notriddle · 2020-08-19T23:16:18Z

rust-lang/compiler-team#347 Is the MCP

src/librustc_lint/traits.rs

notriddle · 2020-09-11T04:52:53Z

@rustbot modify labels: +S-waiting-on-review and -S-waiting-on-author

petrochenkov · 2020-09-11T18:45:44Z

r=me on the implementation after squashing commits.
Looks like this is still waiting on team though (rust-lang/compiler-team#347).

flip1995 · 2020-09-30T22:34:06Z

Should we directly deprecate the lint from Clippy in this PR or do it in Clippy after this PR is merged and sync it back to rustc?

I can guide through the process of deprecating Clippy lints.

spastorino · 2020-09-30T22:44:44Z

This is no longer waiting on team, MCP has been accepted.

bors · 2020-10-01T22:08:44Z

📌 Commit cd159fd has been approved by petrochenkov

…chenkov Uplift drop-bounds lint from clippy Bounds on `T: Drop` do nothing, so they should warn.

bors · 2020-10-02T07:07:41Z

⌛ Testing commit cd159fd with merge 866ac1183a3d7ac82f37bd74092d140977ac13ab...

bors · 2020-10-02T07:51:18Z

💔 Test failed - checks-actions

petrochenkov · 2020-10-02T09:57:06Z

Some clippy tests need to be updated.

flip1995 · 2020-10-02T15:16:52Z

Either we update the Clippy tests here, then sync these changes to Clippy, then deprecate the lint in Clippy, and then sync it back to rustc

or

We deprecate the lint here, don't have to go through the whole sync process twice and make Clippy test-pass at the same time.

Instructions how to deprecate a Clippy lint:

Remove this file:

rust/src/tools/clippy/clippy_lints/src/drop_bounds.rs

Line 1 in 4dedf5e

use crate::utils::{match_def_path, paths, span_lint};
Add this lint to this file

rust/src/tools/clippy/clippy_lints/src/deprecated_lints.rs

Line 1 in 4dedf5e

macro_rules! declare_deprecated_lint {
Remove the test file

rust/src/tools/clippy/tests/ui/drop_bounds.rs

Line 1 in 4dedf5e

#![allow(unused)]
a. ~~temporarily add src/tools/clippy/clippy_dev to workspace.members in the Cargo.toml~~
b. ~~cd into src/tools/clippy and run cargo dev update_lints~~
~~Clean up Clippy until ./x.py check src/tools/clippy passes~~
~~Add a deprecation test and update the deprecated.stderr reference file.~~

Or just apply this patch: https://gist.github.com/flip1995/bbde96b04ca768f4ed7713dd53f23641

flip1995

ACK Clippy change 👍

petrochenkov · 2020-10-03T09:39:30Z

@bors r+

bors · 2020-10-03T09:39:31Z

📌 Commit dceb81a has been approved by petrochenkov

…chenkov Uplift drop-bounds lint from clippy Bounds on `T: Drop` do nothing, so they should warn.

Rollup of 11 pull requests Successful merges: - rust-lang#75143 (Use `tracing` spans to trace the entire MIR interp stack) - rust-lang#75699 (Uplift drop-bounds lint from clippy) - rust-lang#76768 (Test and reject out-of-bounds shuffle vectors) - rust-lang#77190 (updated p! macro to accept literals) - rust-lang#77388 (Add some regression tests) - rust-lang#77419 (Create E0777 error code for invalid argument in derive) - rust-lang#77447 (BTreeMap: document DrainFilterInner better) - rust-lang#77468 (Fix test name) - rust-lang#77469 (Improve rustdoc error for failed intra-doc link resolution) - rust-lang#77473 (Make --all-targets in x.py check opt-in) - rust-lang#77508 (Fix capitalization in blog post name) Failed merges: r? `@ghost`

rust-highfive assigned petrochenkov Aug 19, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 19, 2020

jonas-schievink added the T-lang Relevant to the language team, which will review and decide on the PR/issue. label Aug 19, 2020

notriddle force-pushed the drop-bounds-lint branch from c4ebc01 to eadf7f7 Compare August 19, 2020 10:39

tesuji reviewed Aug 19, 2020

View reviewed changes

src/librustc_lint/traits.rs Outdated Show resolved Hide resolved

notriddle force-pushed the drop-bounds-lint branch from eadf7f7 to 95d5e0d Compare August 19, 2020 18:10

petrochenkov reviewed Aug 19, 2020

View reviewed changes

library/core/src/ops/drop.rs Outdated Show resolved Hide resolved

src/test/ui/drop-bounds/drop-bounds.rs Outdated Show resolved Hide resolved

src/librustc_lint/traits.rs Outdated Show resolved Hide resolved

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2020

Aaron1011 reviewed Aug 19, 2020

View reviewed changes

src/test/ui/drop-bounds/drop-bounds.rs Show resolved Hide resolved

notriddle mentioned this pull request Aug 19, 2020

Uplift drop-bounds lint from clippy into rustc rust-lang/compiler-team#347

Closed

3 tasks

tesuji reviewed Aug 20, 2020

View reviewed changes

src/librustc_lint/traits.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

taiki-e mentioned this pull request Sep 10, 2020

Prepare for uplift of drop-bounds lint taiki-e/pin-project#272

Closed

notriddle force-pushed the drop-bounds-lint branch from ba85cc2 to 0f4e18f Compare September 11, 2020 04:03

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 11, 2020

spastorino added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Sep 30, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 1, 2020

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Oct 1, 2020

Rollup merge of rust-lang#75699 - notriddle:drop-bounds-lint, r=petro…

edf43ea

…chenkov Uplift drop-bounds lint from clippy Bounds on `T: Drop` do nothing, so they should warn.

Dylan-DPC-zz mentioned this pull request Oct 1, 2020

Rollup of 14 pull requests #77437

Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 2, 2020

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 2, 2020

Deprecate clippy lint

dceb81a

flip1995 approved these changes Oct 2, 2020

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 3, 2020

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Oct 3, 2020

Rollup merge of rust-lang#75699 - notriddle:drop-bounds-lint, r=petro…

291f520

…chenkov Uplift drop-bounds lint from clippy Bounds on `T: Drop` do nothing, so they should warn.

Dylan-DPC-zz mentioned this pull request Oct 3, 2020

Rollup of 9 pull requests #77483

Closed

jonas-schievink mentioned this pull request Oct 3, 2020

Rollup of 12 pull requests #77509

Closed

JohnTitor mentioned this pull request Oct 4, 2020

Rollup of 11 pull requests #77517

Merged

bors merged commit b654555 into rust-lang:master Oct 4, 2020

rustbot added this to the 1.49.0 milestone Oct 4, 2020

notriddle deleted the drop-bounds-lint branch October 4, 2020 06:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uplift drop-bounds lint from clippy #75699

Uplift drop-bounds lint from clippy #75699

notriddle commented Aug 19, 2020

rust-highfive commented Aug 19, 2020

petrochenkov commented Aug 19, 2020

notriddle commented Aug 19, 2020

This comment has been minimized.

notriddle commented Sep 11, 2020

petrochenkov commented Sep 11, 2020 •

edited

Loading

flip1995 commented Sep 30, 2020 •

edited

Loading

spastorino commented Sep 30, 2020

bors commented Oct 1, 2020

bors commented Oct 2, 2020

bors commented Oct 2, 2020

petrochenkov commented Oct 2, 2020

flip1995 commented Oct 2, 2020

flip1995 left a comment

petrochenkov commented Oct 3, 2020

bors commented Oct 3, 2020

Uplift drop-bounds lint from clippy #75699

Uplift drop-bounds lint from clippy #75699

Conversation

notriddle commented Aug 19, 2020

rust-highfive commented Aug 19, 2020

petrochenkov commented Aug 19, 2020

notriddle commented Aug 19, 2020

This comment has been minimized.

notriddle commented Sep 11, 2020

petrochenkov commented Sep 11, 2020 • edited Loading

flip1995 commented Sep 30, 2020 • edited Loading

spastorino commented Sep 30, 2020

bors commented Oct 1, 2020

bors commented Oct 2, 2020

bors commented Oct 2, 2020

petrochenkov commented Oct 2, 2020

flip1995 commented Oct 2, 2020

flip1995 left a comment

Choose a reason for hiding this comment

petrochenkov commented Oct 3, 2020

bors commented Oct 3, 2020

petrochenkov commented Sep 11, 2020 •

edited

Loading

flip1995 commented Sep 30, 2020 •

edited

Loading