Include llvm-dis, llc and opt in llvm-tools-preview component
#77868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
llvm-dis is also noted by @glandium here #55890 (comment) -- is there a reason you excluded it? I am personally inclined to include more rather than less in this component, so I am fine with this. cc @rust-lang/release |
Aaron1011
force-pushed
the
llvm-tools-opt-llc
branch
from
77e172b
to
0920dd3
Compare
Aaron1011
changed the title
llc and opt in llvm-tools-preview componentllvm-dis, llc and opt in llvm-tools-preview component
|
@Mark-Simulacrum I added |
Fixes rust-lang#55890 It's useful to have `llc` and `opt` available when debugging an LLVM miscompilation,.
Aaron1011
force-pushed
the
llvm-tools-opt-llc
branch
from
0920dd3
to
c16c8ac
Compare
|
I was just thinking about something like this last week.. thanks! |
|
@bors r+ I'm going to go ahead and approve this but if folks disagree we can revert it / discuss it. |
|
📌 Commit c16c8ac has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 13, 2020
…k-Simulacrum Include `llvm-dis`, `llc` and `opt` in `llvm-tools-preview` component Fixes rust-lang#55890 It's useful to have `llc` and `opt` available when debugging an LLVM miscompilation,.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 13, 2020
…k-Simulacrum Include `llvm-dis`, `llc` and `opt` in `llvm-tools-preview` component Fixes rust-lang#55890 It's useful to have `llc` and `opt` available when debugging an LLVM miscompilation,.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 13, 2020
Rollup of 14 pull requests Successful merges: - rust-lang#77239 (Enable building Cargo for aarch64-apple-darwin) - rust-lang#77569 (BTreeMap: type-specific variants of node_as_mut and cast_unchecked) - rust-lang#77719 (Remove unnecessary rustc_const_stable attributes.) - rust-lang#77722 (Remove unsafety from sys/unsupported and add deny(unsafe_op_in_unsafe_fn).) - rust-lang#77725 (Add regression issue template) - rust-lang#77776 ( Give an error when running `x.py test --stage 0 src/test/ui`) - rust-lang#77786 (Mention rustdoc in `x.py setup`) - rust-lang#77825 (`min_const_generics` diagnostics improvements) - rust-lang#77868 (Include `llvm-dis`, `llc` and `opt` in `llvm-tools-preview` component) - rust-lang#77884 (Use Option::unwrap_or instead of open-coding it) - rust-lang#77886 (Replace trivial bool matches with the `matches!` macro) - rust-lang#77892 (Replace absolute paths with relative ones) - rust-lang#77895 (Include aarch64-apple-darwin in the dist manifests) - rust-lang#77909 (bootstrap: set correct path for the build-manifest binary) Failed merges: - rust-lang#77902 (Include aarch64-pc-windows-msvc in the dist manifests) r? `@ghost`
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55890
It's useful to have
llcandoptavailable when debugging an LLVMmiscompilation,.