Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent no_prelude attribute #80427

Closed

Conversation

Skgland
Copy link
Contributor

@Skgland Skgland commented Dec 28, 2020

Rebases and adjusts the work of the inactive pr #32025 for rust-lang/rfcs#501
with tracking issue #20561

From the original PR:

Adds the no_prelude attribute that stops automatic injecting of the standard prelude in a single module behind a feature gate.
Deprecates the existing no_implicit_prelude.

This version does not deprecate no_implicit_prelude as this appears to be the consent of the discussion of the original pr.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 28, 2020
@Skgland Skgland changed the title Consistent no prelude attribute Consistent no_prelude attribute Dec 28, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Dec 28, 2020

r? @alexcrichton since you reviewed the last PR

@bors
Copy link
Contributor

bors commented Dec 31, 2020

☔ The latest upstream changes (presumably #80530) made this pull request unmergeable. Please resolve the merge conflicts.

@petrochenkov
Copy link
Contributor

The PR is from 2016 and the RFC is from 2014, the whole idea should probably be revised before proceeding.

In recent years #[no_implicit_prelude] was mostly used in compiler tests and by people wanting to stress the compiler, it was also a source of problems during macro modularization and other name resolution changes.
I'd personally be more interested in removing #[no_implicit_prelude] than in adding one more similar attribute.

@Skgland Skgland force-pushed the consistent-no_prelude-attribute branch from 4fc4f35 to 90a6a5e Compare December 31, 2020 15:13
@bors
Copy link
Contributor

bors commented Dec 31, 2020

☔ The latest upstream changes (presumably #80459) made this pull request unmergeable. Please resolve the merge conflicts.

@Skgland Skgland force-pushed the consistent-no_prelude-attribute branch from 90a6a5e to 7f72465 Compare January 1, 2021 23:54
@alexcrichton
Copy link
Member

Er sorry I don't really remember the context of a PR I reviewed 5 (!) years ago at this point. I'm probably not the best reviewer for this. Would you be ok selecting a different reviewer?

r? @oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned alexcrichton Jan 4, 2021
@bors
Copy link
Contributor

bors commented Jan 7, 2021

☔ The latest upstream changes (presumably #80425) made this pull request unmergeable. Please resolve the merge conflicts.

@Skgland Skgland force-pushed the consistent-no_prelude-attribute branch from 7f72465 to 741ff63 Compare January 7, 2021 10:00
@bors
Copy link
Contributor

bors commented Jan 10, 2021

☔ The latest upstream changes (presumably #80867) made this pull request unmergeable. Please resolve the merge conflicts.

@Skgland Skgland force-pushed the consistent-no_prelude-attribute branch from 741ff63 to e3e09d5 Compare January 10, 2021 14:00
@bors
Copy link
Contributor

bors commented Jan 11, 2021

☔ The latest upstream changes (presumably #80782) made this pull request unmergeable. Please resolve the merge conflicts.

@Skgland Skgland force-pushed the consistent-no_prelude-attribute branch from e3e09d5 to f1927e5 Compare January 11, 2021 10:46
@oli-obk
Copy link
Contributor

oli-obk commented Jan 11, 2021

The PR is from 2016 and the RFC is from 2014, the whole idea should probably be revised before proceeding.

In recent years #[no_implicit_prelude] was mostly used in compiler tests and by people wanting to stress the compiler, it was also a source of problems during macro modularization and other name resolution changes.
I'd personally be more interested in removing #[no_implicit_prelude] than in adding one more similar attribute.

I have no real knowledge of this area, but I agree that just the existance of an RFC does not motivate the change, and I'm not sure the original motivation still applies (considering that there was no activity on the tracking issue for years).

cc @Kimundi @Nemo157 how do you feel about abolishing this scheme entirely and coming up with something new that does not conflict with macro imports?

@bors
Copy link
Contributor

bors commented Jan 17, 2021

☔ The latest upstream changes (presumably #81113) made this pull request unmergeable. Please resolve the merge conflicts.

move no-prelude tests to tests/ui
remove duplicate no-implicit-prelude tests
so that #![no_prelude] is not marked as used when it is implied by #![no_implicit_prelude]
@Skgland Skgland force-pushed the consistent-no_prelude-attribute branch from f1927e5 to 2fdbd78 Compare January 17, 2021 22:39
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2021
@Skgland Skgland closed this Mar 2, 2021
@Skgland Skgland deleted the consistent-no_prelude-attribute branch May 22, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants