Allow checking miri and RLS with x.py check src/tools/{miri,rls}
#85051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
Oh hmm I think checking miri needs to be off by default since it's out-of-tree. |
|
If this doesn't add extra maintenance and this adds support for |
Nope, adding things to |
|
cc @RalfJung btw - hopefully this is helpful :) |
jyn514
changed the title
x.py check src/tools/mirix.py check src/tools/{miri,rls}
|
@bors r+ rollup |
|
📌 Commit e4b57e1 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 11, 2021
Rollup of 7 pull requests Successful merges: - rust-lang#84777 (Apply `--cfg parallel_compiler` when documenting) - rust-lang#84783 (Allow formatting specific subdirectories) - rust-lang#84998 (Show nicer error when an 'unstable fingerprints' error occurs) - rust-lang#85002 (RELEASES.md: Use broken_intra_doc_links as an example, not nightly lint) - rust-lang#85051 (Allow checking miri and RLS with `x.py check src/tools/{miri,rls}`) - rust-lang#85114 (Remove outdated FIXME for download-rustc) - rust-lang#85143 (Document Rc::from) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with #80639.
@Xanewok would you find this useful for RLS too?