Fix issue 85435 by restricting Fake Read precision #85724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
roxelo
force-pushed
the
rox-fix-issue-85435
branch
from
522a676
to
31d38f9
Compare
nikomatsakis
approved these changes
May 26, 2021
|
@bors r+ |
|
📌 Commit 31d38f9f7bf485409fc0b127bfdd9aa1ee12ef15 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
|
@bors r- |
bors
added
S-waiting-on-author
|
Do you need to update this PR, then? |
|
@nikomatsakis Yes, I need to update it so we can test it on nightly. Do I need to do something specific so the changes are available on nightly but not backported (I am not sure I fully understood how the backporting works)? |
|
@roxelo no, the default is that whatever PR we land will be on nightly. Backporting is an active step that we take for just some PRs. |
roxelo
force-pushed
the
rox-fix-issue-85435
branch
from
31d38f9
to
382338f
Compare
|
Ok, I have removed the re-added feature gate so this PR should be good to merge. |
|
@bors r+ |
|
📌 Commit 382338f has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jun 3, 2021
…nikomatsakis Fix issue 85435 by restricting Fake Read precision This PR fixes the root bug of issue rust-lang#85435 by restricting Fake Read precision in closures and removing the feature gate introduced in PR rust-lang#85564. More info [here](rust-lang#85561 (comment)) and [here](rust-lang#85561 (comment)). Closes rust-lang#85561 r? `@nikomatsakis`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 3, 2021
Rollup of 13 pull requests Successful merges: - rust-lang#83362 (Stabilize `vecdeque_binary_search`) - rust-lang#85706 (Turn off frame pointer elimination on all Apple platforms. ) - rust-lang#85724 (Fix issue 85435 by restricting Fake Read precision) - rust-lang#85852 (Clarify meaning of MachineApplicable suggestions.) - rust-lang#85877 (Intra doc link-ify a reference to a function) - rust-lang#85880 (convert assertion on rvalue::threadlocalref to delay bug) - rust-lang#85896 (Add test for forward declared const param defaults) - rust-lang#85897 (Update I-unsound label for triagebot) - rust-lang#85900 (Use pattern matching instead of checking lengths explicitly) - rust-lang#85911 (Avoid a clone of output_filenames.) - rust-lang#85926 (Update cargo) - rust-lang#85934 (Add `Ty::is_union` predicate) - rust-lang#85935 (Validate type of locals used as indices) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
2021 Edition Blockers
automation
moved this from Feature Complete Blockers
to Completed items
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the root bug of issue #85435 by restricting Fake Read precision in closures and removing the feature gate introduced in PR #85564. More info here and here.
Closes #85561
r? @nikomatsakis