Remove unused feature gates #85850
Remove unused feature gates #85850
Conversation
It has been possible to clone closures for a while now
bjorn3
added
C-cleanup
|
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
bjorn3
force-pushed
the
less_feature_gates
branch
from
336d3c1
to
56fbb61
Compare
This comment has been minimized.
This comment has been minimized.
bjorn3
force-pushed
the
less_feature_gates
branch
from
56fbb61
to
312f964
Compare
| @@ -65,7 +65,7 @@ impl Idx for u32 { | |||
| /// `u32::MAX`. You can also customize things like the `Debug` impl, | |||
| /// what traits are derived, and so forth via the macro. | |||
| #[macro_export] | |||
| #[allow_internal_unstable(step_trait, rustc_attrs)] | |||
| #[allow_internal_unstable(step_trait, rustc_attrs, trusted_step)] | |||
There was a problem hiding this comment.
Can you explain what this does? I don't know how allow_internal_unstable works.
There was a problem hiding this comment.
allow_internal_unstable allows a macro to use a feature gate without having to enable the feature gate in the target crate. This is for example used by libstd to allow panic!() to call an unstable function to start panicking without the user having to enable the respective feature gate.
There was a problem hiding this comment.
Ok, that seems fine in the compiler itself.
There was a problem hiding this comment.
Wait, how does that work? Aren't feature gates checked after macro expansion usually?
There was a problem hiding this comment.
The expansion data retrievable based on the expansion id stored in a span contains a field with all allow_internal_unstable feature gates set for the expanding macro. span.allows_unstable(feature) checks this list.
|
@bors r+ |
|
📌 Commit 312f964 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 312f964 with merge ed81246d7655b118fc693db9475aa39a91b0a0f0... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Spurious network error. @bors retry |
bors
added
S-waiting-on-bors
Rollup of 8 pull requests Successful merges: - rust-lang#85717 (Document `From` impls for cow.rs) - rust-lang#85850 (Remove unused feature gates) - rust-lang#85888 (Fix typo in internal documentation for `TrustedRandomAccess`) - rust-lang#85889 (Restoring the `num_def_ids` function in the CStore API ) - rust-lang#85899 (jsondocck small cleanup) - rust-lang#85937 (Fix bad suggestions for code from proc_macro) - rust-lang#85963 (Show `::{{constructor}}` in std::any::type_name().) - rust-lang#85977 (Fix linkcheck script from getting out of sync.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
The first commit removes a usage of a feature gate, but I don't expect it to be controversial as the feature gate was only used to workaround a limitation of rust in the past. (closures never being
Clone)The second commit uses
#[allow_internal_unstable]to avoid leaking thetrusted_stepfeature gate usage from inside the index newtype macro. It didn't work for themin_specializationfeature gate though.The third commit removes (almost) all feature gates from the compiler that weren't used anyway.