Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new tool to check HTML #86059

Merged
merged 3 commits into from
Jun 29, 2021
Merged

Add new tool to check HTML #86059

merged 3 commits into from
Jun 29, 2021

Conversation

GuillaumeGomez
Copy link
Member

Re-opening of #84480.

r? @Mark-Simulacrum

@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jun 6, 2021
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 6, 2021
@Mark-Simulacrum
Copy link
Member

I'd like this to use the same logic as added by #86152 (once it lands) to make sure we're lazily evaluating the condition here. Otherwise broadly looks good but I'd like to take another look before final r+ once this is updated.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2021
@GuillaumeGomez GuillaumeGomez added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 23, 2021
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Jun 24, 2021 •
edited
Loading

Updated! I added the lazy check as well.

Mark-Simulacrum
Mark-Simulacrum approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with nit fixed

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez
Copy link
Member Author

@bors: r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Jun 28, 2021

📌 Commit d0b1443f2751e8f956d54155dca37a7c60da9b48 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 28, 2021
@Mark-Simulacrum
Copy link
Member

If you could squash commits that would also be good.

@GuillaumeGomez
Copy link
Member Author

Doing that!

@bors: r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 28, 2021
@GuillaumeGomez
Add new tool to check HTML:
83a2bc3 
 * Make html-checker run by default on rust compiler docs as well
 * Ensure html-checker is run on CI
 * Lazify tidy binary presence check
@GuillaumeGomez
Install tidy on x86_64-gnu-aux target to run html check
af37ed7
@GuillaumeGomez
Only run HTML check on rustdoc generated items
785b705
@GuillaumeGomez
Copy link
Member Author

I kept the "specialized" commits on their own, merged the others together.

@bors: r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Jun 28, 2021

📌 Commit 785b705 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 28, 2021
@JohnTitor JohnTitor mentioned this pull request Jun 28, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 29, 2021
@bors
Auto merge of rust-lang#86704 - JohnTitor:rollup-lnrxo4i, r=JohnTitor
1ea0e28 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#86059 (Add new tool to check HTML)
 - rust-lang#86529 (Add support for OpenSSL 3.0.0)
 - rust-lang#86657 (Fix `future_prelude_collision` false positive)
 - rust-lang#86661 (Editon 2021 enables precise capture)
 - rust-lang#86671 (Turn non_fmt_panic into a future_incompatible edition lint.)
 - rust-lang#86673 (Make disjoint_capture_migration an edition lint.)
 - rust-lang#86678 (Fix garbled suggestion for missing lifetime specifier)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b5d4343 into rust-lang:master Jun 29, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jun 29, 2021
@GuillaumeGomez GuillaumeGomez deleted the html-checker2 branch June 29, 2021 08:15
@notriddle notriddle mentioned this pull request Apr 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@GuillaumeGomez @Mark-Simulacrum @rust-log-analyzer @bors @rust-highfive @rustbot