Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize maybe_uninit_ref #86273

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Stabilize maybe_uninit_ref #86273

merged 1 commit into from
Jun 14, 2021

Conversation

JohnTitor
Copy link
Member

This stabilizes assume_init_{ref,mut}. FCP is complete: #63568 (comment)
The renaming was done by #76047 and FIXME was resolved by #76241, so I think we can now stabilize them finally 🎉
Still, it's const-unstable as assert_inhabited is unstable.

Closes #63568

@rust-highfive
Copy link
Collaborator

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 13, 2021
@JohnTitor
Copy link
Member Author

cc @RalfJung

@JohnTitor
Copy link
Member Author

Btw, should we also rename them on https://rust-lang.github.io/rfcs/1892-uninitialized-uninhabited.html#detailed-design?

@jonas-schievink jonas-schievink added the relnotes Marks issues that should be documented in the release notes of the next release. label Jun 13, 2021
@RalfJung
Copy link
Member

Btw, should we also rename them on https://rust-lang.github.io/rfcs/1892-uninitialized-uninhabited.html#detailed-design?

We don't usually update RFCs. They reflect the consensus at the time, they are not documentation of the current state of affairs.

@RalfJung
Copy link
Member

r? @RalfJung
Thanks. :)
Considering that this has been FCP'd more than a year ago, I think I can just approve this. Still Cc @rust-lang/libs

@bors r+

@bors
Copy link
Contributor

bors commented Jun 14, 2021

📌 Commit 7fa1308 has been approved by RalfJung

@rust-highfive rust-highfive assigned RalfJung and unassigned dtolnay Jun 14, 2021
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 14, 2021
@bors
Copy link
Contributor

bors commented Jun 14, 2021

⌛ Testing commit 7fa1308 with merge a216131...

@bors
Copy link
Contributor

bors commented Jun 14, 2021

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing a216131 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 14, 2021
@bors bors merged commit a216131 into rust-lang:master Jun 14, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jun 14, 2021
@JohnTitor JohnTitor deleted the stabilize-maybe-uninit-ref branch June 14, 2021 20:06
@est31 est31 mentioned this pull request Jun 16, 2021
Merged
@jonas-schievink jonas-schievink added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Jul 17, 2021
@cuviper cuviper mentioned this pull request Jul 22, 2021
Merged
yvt added a commit to r3-os/r3 that referenced this pull request Dec 5, 2021
@yvt
fix: remove #![feature(maybe_uninit_ref)]
550be96 
It's been stabilized by <rust-lang/rust#86273>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

Assignees

@RalfJung RalfJung

Labels
merged-by-bors This PR was explicitly merged by bors. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.

Tracking issue for #![feature(maybe_uninit_ref)]
7 participants
@JohnTitor @rust-highfive @RalfJung @bors @jonas-schievink @dtolnay @rustbot