Skip to content

Conversation

fee1-dead
Copy link
Member

Fixes #86464

@rust-highfive
Copy link
Contributor

r? @ollie27

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 19, 2021
@fee1-dead
Copy link
Member Author

Screenshot:
image

The unstable is linked to the tracking issue. Should I change the color?

@jyn514
Copy link
Member

jyn514 commented Jun 21, 2021

The unstable is linked to the tracking issue.

This is awesome, thank you ❤️ No, I don't think the color needs to change - I like that it's a different color because it gives you a hint it's a link.

@jyn514 jyn514 added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jun 21, 2021
@fee1-dead fee1-dead force-pushed the rustdoc-const-unstable branch 2 times, most recently from 51d8b48 to c4396f4 Compare June 21, 2021 03:18
@jyn514
Copy link
Member

jyn514 commented Jun 21, 2021

@bors r+

Thanks for the fix!

@bors
Copy link
Collaborator

bors commented Jun 21, 2021

📌 Commit b57077b has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 21, 2021
Rollup of 9 pull requests

Successful merges:

 - rust-lang#86192 (Make OR_PATTERNS_BACK_COMPAT be a 2021 future-incompatible lint)
 - rust-lang#86248 (Add a regression test for issue-85113)
 - rust-lang#86274 (Spaces)
 - rust-lang#86349 (Add regression test for issue rust-lang#78632)
 - rust-lang#86424 (rustfmt: load nested out-of-line mods correctly)
 - rust-lang#86472 (Fix CI to fetch master on beta channel)
 - rust-lang#86473 (Rustdoc: Account for const-unstable functions)
 - rust-lang#86495 (Improve `proc_macro::{Punct, Spacing}` documentation)
 - rust-lang#86503 (Fix rust.css fonts.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f3fe5c3 into rust-lang:master Jun 21, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jun 21, 2021
@fee1-dead fee1-dead deleted the rustdoc-const-unstable branch June 30, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustdoc rendering for stable-but-const-unstable const fn is misleading
6 participants