Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not panic in return_type_impl_trait #86505

Merged
merged 3 commits into from
Jun 25, 2021
Merged

Do not panic in return_type_impl_trait #86505

merged 3 commits into from
Jun 25, 2021

Conversation

JohnTitor
Copy link
Member

Fixes #86483

@rust-highfive
Copy link
Collaborator

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 21, 2021
jackh726
jackh726 approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to enumerate the Items that are relevant (i.e. closures and fn items), rather than checking for items to return early from.

r=me with that, or as is

@JohnTitor
Copy link
Member Author

@jackh726 Applied your suggestion, could you take a look once more in case I overlook some cases?

@jackh726
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 24, 2021

📌 Commit 9323a28 has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2021
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Jun 24, 2021
@m-ou-se
Rollup merge of rust-lang#86505 - JohnTitor:fix-86483, r=jackh726
4138cf4 
Do not panic in `return_type_impl_trait`

Fixes rust-lang#86483
@m-ou-se m-ou-se mentioned this pull request Jun 24, 2021
Closed
@bors
Copy link
Contributor

bors commented Jun 25, 2021

⌛ Testing commit 9323a28 with merge 117799b...

@bors
Copy link
Contributor

bors commented Jun 25, 2021

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 117799b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 25, 2021
@bors bors merged commit 117799b into rust-lang:master Jun 25, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jun 25, 2021
@JohnTitor JohnTitor deleted the fix-86483 branch June 25, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackh726 jackh726 jackh726 approved these changes

Assignees

@jackh726 jackh726

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.

thread 'rustc' panicked at 'Box<Any>': associated type missing default
5 participants
@JohnTitor @rust-highfive @jackh726 @bors @rustbot