Skip to content

Rename all_crate_nums query to crates and remove useless wrapper #86749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2021
Merged

Rename all_crate_nums query to crates and remove useless wrapper #86749

merged 1 commit into from
Jul 1, 2021

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Jun 30, 2021

Split out of #86105

r? @petrochenkov

@rust-highfive
Copy link
Contributor

Some changes occurred in src/tools/clippy.

cc @rust-lang/clippy

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 30, 2021
@bjorn3 bjorn3 force-pushed the link_info_refactor_part1 branch from 3e98072 to e80791a Compare June 30, 2021 16:01
@bjorn3
Copy link
Member Author

bjorn3 commented Jun 30, 2021

@bors try @rust-timer queue as #86105 was a regression.

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 30, 2021
@bors
Copy link
Collaborator

bors commented Jun 30, 2021

⌛ Trying commit e80791a78c33504fe7da2ba98b8dd79f7a48b20f with merge 227bca628a6d22801d76a0cb5b0983c2f10b02b6...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2021
@bors
Copy link
Collaborator

bors commented Jun 30, 2021

☀️ Try build successful - checks-actions
Build commit: 227bca628a6d22801d76a0cb5b0983c2f10b02b6 (227bca628a6d22801d76a0cb5b0983c2f10b02b6)

@rust-timer
Copy link
Collaborator

Queued 227bca628a6d22801d76a0cb5b0983c2f10b02b6 with parent 5d34076, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (227bca628a6d22801d76a0cb5b0983c2f10b02b6): comparison url.

Summary: This benchmark run did not return any significant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 30, 2021
@petrochenkov petrochenkov removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 30, 2021
@petrochenkov
Copy link
Contributor

r=me with tidy fixed.

@bjorn3 bjorn3 force-pushed the link_info_refactor_part1 branch from e80791a to c7d2099 Compare July 1, 2021 14:51
@bjorn3
Copy link
Member Author

bjorn3 commented Jul 1, 2021

Rustfm'ed

@bors r=petrochenkov

@bors
Copy link
Collaborator

bors commented Jul 1, 2021

📌 Commit c7d2099 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 1, 2021
@bors
Copy link
Collaborator

bors commented Jul 1, 2021

⌛ Testing commit c7d2099 with merge 7100b31...

@bors
Copy link
Collaborator

bors commented Jul 1, 2021

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 7100b31 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 1, 2021
@bors bors merged commit 7100b31 into rust-lang:master Jul 1, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 1, 2021
@rust-highfive rust-highfive mentioned this pull request Jul 1, 2021
Closed
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #86749!

Tested on commit 7100b31.
Direct link to PR: #86749

💔 miri on windows: test-pass → build-fail (cc @eddyb @oli-obk @RalfJung).
💔 miri on linux: test-pass → build-fail (cc @eddyb @oli-obk @RalfJung).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jul 1, 2021
@rust-highfive
📣 Toolstate changed by rust-lang/rust#86749!
77a1c58 
Tested on commit rust-lang/rust@7100b31.
Direct link to PR: <rust-lang/rust#86749>

💔 miri on windows: test-pass → build-fail (cc @eddyb @oli-obk @RalfJung).
💔 miri on linux: test-pass → build-fail (cc @eddyb @oli-obk @RalfJung).
@bors bors mentioned this pull request Jul 1, 2021
Closed
@bjorn3 bjorn3 deleted the link_info_refactor_part1 branch July 1, 2021 22:07
@bors bors mentioned this pull request Jul 1, 2021
Merged
JohnTitor added a commit to JohnTitor/rust-semverver that referenced this pull request Jul 15, 2021
@JohnTitor
Rustup to rust-lang/rust#86749
8c48b8a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.
7 participants
@bjorn3 @rust-highfive @rust-timer @bors @rust-log-analyzer @petrochenkov @rustbot