Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding explicit notice of lack of documentation for Tier 2 Platforms #87677

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

amalik18
Copy link

@amalik18 amalik18 commented Aug 1, 2021

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 1, 2021
@Mark-Simulacrum
Copy link
Member

It looks like a bunch of unrelated changes snuck in here, possibly due to the merge commit - please rebase instead of merging within PRs. Thanks!

@amalik18
Copy link
Author

amalik18 commented Aug 3, 2021

It looks like a bunch of unrelated changes snuck in here, possibly due to the merge commit - please rebase instead of merging within PRs. Thanks!

Any good way of squashing all of them?

@amalik18 amalik18 force-pushed the issue-2788-fix branch 2 times, most recently from 45bca0c to 360a0a4 Compare August 3, 2021 01:27
@rust-log-analyzer

This comment has been minimized.

@jyn514
Copy link
Member

jyn514 commented Aug 3, 2021

@amalik18
Copy link
Author

amalik18 commented Aug 3, 2021

@jyn514 yep it should be good to go

@amalik18 amalik18 requested a review from jyn514 August 5, 2021 02:34
@jyn514
Copy link
Member

jyn514 commented Aug 5, 2021

@amalik18 I'm not planning to review this - @steveklabnik is assigned and they're a good reviewer for this :)

@amalik18
Copy link
Author

amalik18 commented Aug 5, 2021

@amalik18 I'm not planning to review this - @steveklabnik is assigned and they're a good reviewer for this :)

My bad, it listed you in the reviewers section.

@pietroalbini
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 14, 2021

📌 Commit 4ffb1ef has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2021
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 15, 2021
…bini

Adding explicit notice of lack of documentation for Tier 2 Platforms

Fixing: rust-lang/rustup#2788
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 15, 2021
…bini

Adding explicit notice of lack of documentation for Tier 2 Platforms

Fixing: rust-lang/rustup#2788
This was referenced Aug 15, 2021
camsteffen added a commit to camsteffen/rust that referenced this pull request Aug 15, 2021
…bini

Adding explicit notice of lack of documentation for Tier 2 Platforms

Fixing: rust-lang/rustup#2788
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Aug 16, 2021
…bini

Adding explicit notice of lack of documentation for Tier 2 Platforms

Fixing: rust-lang/rustup#2788
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 16, 2021
Rollup of 10 pull requests

Successful merges:

 - rust-lang#87178 ([rustdoc] Copy only item path to clipboard rather than full `use` statement.)
 - rust-lang#87677 (Adding explicit notice of lack of documentation for Tier 2 Platforms)
 - rust-lang#87958 (Closure migration multispan suggestions)
 - rust-lang#87967 (Detect fake spans in non_fmt_panic lint.)
 - rust-lang#88011 (Enable `--all-targets` for `x.py check` unconditionally)
 - rust-lang#88030 (Assign FIXMEs to me and remove obsolete ones)
 - rust-lang#88052 (Update redox_syscall)
 - rust-lang#88055 (Update RELEASES.md for 1.55.0)
 - rust-lang#88080 (Skip assert ICE with default_method_body_is_const)
 - rust-lang#88089 (Rustdoc font test)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 84ca374 into rust-lang:master Aug 17, 2021
@rustbot rustbot added this to the 1.56.0 milestone Aug 17, 2021
@amalik18 amalik18 deleted the issue-2788-fix branch August 30, 2021 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants