Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: Stabilize command_access #88436

Merged
merged 2 commits into from Oct 9, 2021
Merged

Conversation

lf-
Copy link
Contributor

@lf- lf- commented Aug 28, 2021

Tracking issue: #44434 (not yet closed but the FCP is done so that should be soon).

@rust-highfive
Copy link
Collaborator

r? @yaahc

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 28, 2021
@the8472 the8472 added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Sep 8, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2021
@yaahc
Copy link
Member

yaahc commented Oct 5, 2021

This has already been approved in the tracking issue so I'm not gonna run another FCP, though there is some weirdness with the FCP checkboxes that I'm double checking in zulip first.

Copy link
Member

@yaahc yaahc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to update the version field

library/std/src/process.rs Outdated Show resolved Hide resolved
library/std/src/process.rs Outdated Show resolved Hide resolved
library/std/src/process.rs Outdated Show resolved Hide resolved
library/std/src/process.rs Outdated Show resolved Hide resolved
library/std/src/process.rs Outdated Show resolved Hide resolved
library/std/src/process.rs Outdated Show resolved Hide resolved
library/std/src/process.rs Outdated Show resolved Hide resolved
library/std/src/sys_common/process.rs Outdated Show resolved Hide resolved
library/std/src/sys_common/process.rs Outdated Show resolved Hide resolved
library/std/src/sys_common/process.rs Outdated Show resolved Hide resolved
@yaahc
Copy link
Member

yaahc commented Oct 8, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Oct 8, 2021

📌 Commit 5e1941c has been approved by yaahc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2021
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Oct 9, 2021
std: Stabilize command_access

Tracking issue: rust-lang#44434 (not yet closed but the FCP is done so that should be soon).
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 9, 2021
…laumeGomez

Rollup of 6 pull requests

Successful merges:

 - rust-lang#75644 (Add 'core::array::from_fn' and 'core::array::try_from_fn')
 - rust-lang#87528 (stack overflow handler specific openbsd change.)
 - rust-lang#88436 (std: Stabilize command_access)
 - rust-lang#89614 (Update to Unicode 14.0)
 - rust-lang#89664 (Add documentation to boxed conversions)
 - rust-lang#89700 (Fix invalid HTML generation for higher bounds)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 703cb97 into rust-lang:master Oct 9, 2021
@rustbot rustbot added this to the 1.57.0 milestone Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants