2229 migrations small cleanup #90074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use array explicitly instead of vec for const content (even if optimizer smart enought to remove allocation)
…zer smart enought to remove allocation)
|
r? @wesleywiser (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
rust/compiler/rustc_typeck/src/check/upvar.rs Lines 878 to 885 in 1af55d1 This can be candidate for converting into array too, but i don't know is it worth it. |
wesleywiser
approved these changes
Oct 20, 2021
|
We could also just use a slice ( @bors r+ rollup |
|
📌 Commit f3fb821 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 20, 2021
2229 migrations small cleanup This removes needless `format!`'ing of empty string and replaces `vec!` with const strings with const array.
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Oct 20, 2021
2229 migrations small cleanup This removes needless `format!`'ing of empty string and replaces `vec!` with const strings with const array.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 21, 2021
2229 migrations small cleanup This removes needless `format!`'ing of empty string and replaces `vec!` with const strings with const array.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 21, 2021
Rollup of 14 pull requests Successful merges: - rust-lang#86984 (Reject octal zeros in IPv4 addresses) - rust-lang#87440 (Remove unnecessary condition in Barrier::wait()) - rust-lang#88644 (`AbstractConst` private fields) - rust-lang#89292 (Stabilize CString::from_vec_with_nul[_unchecked]) - rust-lang#90010 (Avoid overflow in `VecDeque::with_capacity_in()`.) - rust-lang#90029 (Add test for debug logging during incremental compilation) - rust-lang#90031 (config: add the option to enable LLVM tests) - rust-lang#90048 (Add test for line-number setting) - rust-lang#90071 (Remove hir::map::blocks and use FnKind instead) - rust-lang#90074 (2229 migrations small cleanup) - rust-lang#90077 (Make `From` impls of NonZero integer const.) - rust-lang#90097 (Add test for duplicated sidebar entries for reexported macro) - rust-lang#90098 (Add test to ensure that the missing_doc_code_examples is not triggered on foreign trait implementations) - rust-lang#90099 (Fix MIRI UB in `Vec::swap_remove`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes needless
format!'ing of empty string and replacesvec!with const strings with const array.