Skip to content

Conversation

GuillaumeGomez
Copy link
Member

Fixes #92973.

We did well adding this test since there was a bug:

Screenshot from 2022-01-25 17-05-48

r? @jsha

@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Jan 25, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 25, 2022
@jsha
Copy link
Contributor

jsha commented Jan 29, 2022

@bors r+ rollup

Thanks!

@bors
Copy link
Collaborator

bors commented Jan 29, 2022

📌 Commit 066fcb6 has been approved by jsha

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 29, 2022
…askrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#88205 (Add Explanation For Error E0772)
 - rust-lang#92274 (Add `intrinsics::const_deallocate`)
 - rust-lang#93236 (Make `NonNull::new` `const`)
 - rust-lang#93299 (Fix dot separator when there is no source link)
 - rust-lang#93410 (kmc-solid: Implement `net::FileDesc::duplicate`)
 - rust-lang#93424 (fix nit)
 - rust-lang#93431 (remove unused `jemallocator` crate)
 - rust-lang#93453 (Add GUI theme change test)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f5f2d44 into rust-lang:master Jan 29, 2022
@rustbot rustbot added this to the 1.60.0 milestone Jan 29, 2022
@GuillaumeGomez GuillaumeGomez deleted the dot-separator-no-source branch January 29, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "dot separator" test in case there is no source link
5 participants