Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move {core,std}::stream::Stream to {core,std}::async_iter::AsyncIterator #93613

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

crlf0710
Copy link
Member

@crlf0710 crlf0710 commented Feb 3, 2022

Following amendments in rust-lang/rfcs#3208.

cc #79024
cc @yoshuawuyts @joshtriplett

@rust-highfive
Copy link
Collaborator

r? @yaahc

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 3, 2022
@crlf0710 crlf0710 added A-async-await Area: Async & Await WG-async Working group: Async & await labels Feb 3, 2022
library/core/src/async_iter/async_iter.rs Outdated Show resolved Hide resolved
library/core/src/async_iter/mod.rs Outdated Show resolved Hide resolved
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches the changes in the updated RFC, and this looks good overall! - This should be good to merge once the typos have been fixed. Once this is merged we should update the tracking issue as well to reflect the new feature name.

Excellent work!

@crlf0710
Copy link
Member Author

crlf0710 commented Feb 3, 2022

Squashed and rebased, thanks!

@crlf0710 crlf0710 added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Feb 5, 2022
@yaahc
Copy link
Member

yaahc commented Feb 16, 2022

Looks good to me. Thank you @crlf0710!

@bors r+

@bors
Copy link
Contributor

bors commented Feb 16, 2022

📌 Commit 18130a2 has been approved by yaahc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 16, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 17, 2022
Move `{core,std}::stream::Stream` to `{core,std}::async_iter::AsyncIterator`

Following amendments in rust-lang/rfcs#3208.

cc rust-lang#79024
cc `@yoshuawuyts` `@joshtriplett`
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 18, 2022
…askrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#92683 (Suggest copying trait associated type bounds on lifetime error)
 - rust-lang#92933 (Deny mixing bin crate type with lib crate types)
 - rust-lang#92959 (Add more info and suggestions to use of #[test] on invalid items)
 - rust-lang#93024 (Do not ICE when inlining a function with un-satisfiable bounds)
 - rust-lang#93613 (Move `{core,std}::stream::Stream` to `{core,std}::async_iter::AsyncIterator`)
 - rust-lang#93634 (compiler: clippy::complexity fixes)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f1c918f into rust-lang:master Feb 18, 2022
@rustbot rustbot added this to the 1.60.0 milestone Feb 18, 2022
@crlf0710 crlf0710 deleted the rename_to_async_iter branch August 10, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-async-await Area: Async & Await S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. WG-async Working group: Async & await
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants