Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to correct as_mut in docs for pointer::as_ref #96336

Merged
merged 1 commit into from
May 8, 2022
Merged

Link to correct as_mut in docs for pointer::as_ref #96336

merged 1 commit into from
May 8, 2022

Conversation

Noratrieb
Copy link
Member

It previously linked to the unstable const-mut-cast method instead of
the mut counterpart for as_ref.

Closes #96327

@Noratrieb
Link to correct as_mut in docs for pointer::as_ref
521bb81 
It previously linked to the unstable const-mut-cast method instead of
the `mut` counterpart for `as_ref`.
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Apr 23, 2022
@rust-highfive
Copy link
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @yaahc

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 23, 2022
@jyn514
Copy link
Member

jyn514 commented Apr 23, 2022

(This is probably a good time to also review any code using feature(intra_doc_pointers), which has exactly the same issue.)

@yaahc
Copy link
Member

yaahc commented Apr 29, 2022

I'm reassigning this PR because I'm taking a break from the review rotation for a little while. Thank you for your patience.

r? rust-lang/libs

@rust-highfive rust-highfive assigned kennytm and unassigned yaahc Apr 29, 2022
@JohnTitor
Copy link
Member

(This is probably a good time to also review any code using feature(intra_doc_pointers), which has exactly the same issue.)

I think we don't have to block this anyway, though it'd be great. Maybe it's worth converting into an issue to audit them.

r? @JohnTitor @bors r+ rollup

@bors
Copy link
Contributor

bors commented May 7, 2022

📌 Commit 521bb81 has been approved by JohnTitor

@rust-highfive rust-highfive assigned JohnTitor and unassigned kennytm May 7, 2022
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request May 7, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 7, 2022
@bors
Auto merge of rust-lang#96824 - matthiaskrgr:rollup-silw3ki, r=matthi…
e612ce9 
…askrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#96336 (Link to correct `as_mut` in docs for `pointer::as_ref`)
 - rust-lang#96586 (Add aliases for std::fs::canonicalize)
 - rust-lang#96667 (Add regression test)
 - rust-lang#96671 (Remove hard links from `env::current_exe` security example)
 - rust-lang#96726 (Add regression and bug tests)
 - rust-lang#96756 (Enable compiler-docs by default for `compiler`, `codegen`, and `tools` profiles)
 - rust-lang#96757 (Don't constantly rebuild clippy on `x test src/tools/clippy`.)
 - rust-lang#96769 (Remove `adx_target_feature` feature from active features list)
 - rust-lang#96777 (Make the test `check-pass` not to produce a JSON file)
 - rust-lang#96822 (Enforce quote rule for JS source code)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1386a02 into rust-lang:master May 8, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 8, 2022
@Noratrieb Noratrieb deleted the link-to-correct-as_mut-in-ptr-as_ref branch May 8, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.

Docs for pointer as_ref links to wrong as_mut
8 participants
@Noratrieb @rust-highfive @jyn514 @yaahc @JohnTitor @bors @kennytm @rustbot