Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rustc_deprecated diagnostics #98115

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Remove rustc_deprecated diagnostics #98115

merged 1 commit into from
Jun 15, 2022

Conversation

jhpratt
Copy link
Member

@jhpratt jhpratt commented Jun 14, 2022

Follow-up on #95960. The diagnostics will remain until the next bootstrap, at which point people will have had six weeks to adjust.

@rustbot label +A-diagnostics

r? @compiler-errors

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 14, 2022
@rustbot rustbot added the A-diagnostics Area: Messages for errors, warnings, and lints label Jun 14, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 14, 2022
@compiler-errors
Copy link
Member

The diagnostics will remain until the next bootstrap, at which point people will have had six weeks to adjust.

You mean that the diagnostic will remain for those working internally in the compiler (and bootstrapping with beta), right? Cause if anyone's using this externally (which, presumably, they shouldn't), it's deprecated next nightly with this PR.

Just getting an idea of the implications of this PR. It LGTM otherwise.

@jhpratt
Copy link
Member Author

jhpratt commented Jun 14, 2022

Yes, I meant for people working on the compiler. Anyone external…well that's what you get for using an internal attribute.

@compiler-errors
Copy link
Member

Cool, thank you for clarifying. Anyways, just for the record, stage2 builds would also break with this PR landed I think?

But yeah, it's an internal attribute.

@bors r+

@bors
Copy link
Contributor

bors commented Jun 14, 2022

📌 Commit 3799d2da84c1a9fc41de5a702e8b4fa0fee9da21 has been approved by compiler-errors

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 14, 2022
@jhpratt
Copy link
Member Author

jhpratt commented Jun 14, 2022

I think? I'm not super familiar with the different stages.

@compiler-errors
Copy link
Member

Stage 2 builds the compiler and stdlib with the stage 1 artifacts, so if we have any stray rustc_deprecated in the codebase, then they would break immediately with these changes landed. Regardless, bors will not merge this if stage 2 is broken, so this isn't risky to land IMO.

@jhpratt
Copy link
Member Author

jhpratt commented Jun 14, 2022

Any #[rustc_deprecated] would have already been an error before this change, just with a diagnostic. So there's definitely not any stray (I checked again regardless).

@compiler-errors
Copy link
Member

Ah, I didn't see it was an error, I thought it was just a warning before. Thanks for double-checking anyways!

@jhpratt
Copy link
Member Author

jhpratt commented Jun 14, 2022

Forgot to bless the test after removing a line. Should be set now.

@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jun 14, 2022

📌 Commit fb05b53 has been approved by compiler-errors

@Dylan-DPC Dylan-DPC mentioned this pull request Jun 15, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 15, 2022
@Dylan-DPC
Rollup merge of rust-lang#98115 - jhpratt:remove-rustc_deprecated, r=…
2b403ff 
…compiler-errors

Remove `rustc_deprecated` diagnostics

Follow-up on rust-lang#95960. The diagnostics will remain until the next bootstrap, at which point people will have had six weeks to adjust.

`@rustbot` label +A-diagnostics

r? `@compiler-errors`
@JohnTitor JohnTitor mentioned this pull request Jun 15, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 15, 2022
@bors
Auto merge of rust-lang#98131 - JohnTitor:rollup-c17vjdy, r=JohnTitor
a4cec97 
Rollup of 3 pull requests

Successful merges:

 - rust-lang#95118 (Implement stabilization of `#[feature(io_safety)]`.)
 - rust-lang#98110 (Make `ExprKind::Closure` a struct variant.)
 - rust-lang#98115 (Remove `rustc_deprecated` diagnostics)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b1e5472 into rust-lang:master Jun 15, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 15, 2022
@jhpratt jhpratt deleted the remove-rustc_deprecated branch June 15, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
A-diagnostics Area: Messages for errors, warnings, and lints S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jhpratt @compiler-errors @bors @rust-highfive @rustbot