-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: use <details> tag for the source code sidebar #98773
rustdoc: use <details> tag for the source code sidebar #98773
Conversation
This fixes the extremely poor accessibility of the old system, making it possible to navigate the sidebar by keyboard, and also implicitly gives the sidebar items the correct ARIA roles.
(rust-highfive has picked a reviewer for you, use r? to override) |
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha Some changes occurred in HTML/CSS themes. A change occurred in the Ayu theme. cc @Cldfire |
This comment has been minimized.
This comment has been minimized.
b0939ca
to
1f621fb
Compare
@GuillaumeGomez In response to #98772 (comment) I see it now. Here's a version with some more spacing added inside the source view sidebar: |
Can you just add a test for the |
@GuillaumeGomez Sure, test case added. |
Thanks! @bors r+ rollup |
📌 Commit e710ac1 has been approved by |
…details, r=GuillaumeGomez rustdoc: use <details> tag for the source code sidebar This fixes the extremely poor accessibility of the old system, making it possible to navigate the sidebar by keyboard, and also implicitly gives the sidebar items the correct ARIA roles. Split out separately from rust-lang#98772
…details, r=GuillaumeGomez rustdoc: use <details> tag for the source code sidebar This fixes the extremely poor accessibility of the old system, making it possible to navigate the sidebar by keyboard, and also implicitly gives the sidebar items the correct ARIA roles. Split out separately from rust-lang#98772
Rollup of 4 pull requests Successful merges: - rust-lang#94831 (Link to stabilization section in std-dev-guide for library tracking issue template) - rust-lang#98764 (add Miri to the nightly docs) - rust-lang#98773 (rustdoc: use <details> tag for the source code sidebar) - rust-lang#98799 (Fix bug in `rustdoc -Whelp`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This fixes the extremely poor accessibility of the old system, making it possible to navigate the sidebar by keyboard, and also implicitly gives the sidebar items the correct ARIA roles.
Split out separately from #98772