Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop using FnCtxt outside of hir typeck #99015

Merged
merged 7 commits into from
Jul 15, 2022
Merged

stop using FnCtxt outside of hir typeck #99015

merged 7 commits into from
Jul 15, 2022

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Jul 7, 2022 •
edited
Loading

the requirements between hir typeck™, and not hir typeck™ are different enough to warrant a full split. with this PR FnCtxt is now only used for hir typeck (and for one clippy lint which seems to be emulating hir typeck).

Once this PR has landed I intend to move FnCtxt into a new crate. This should also allow some further general improvements here.

r? rust-lang/types

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 7, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 7, 2022
@lcnr lcnr marked this pull request as ready for review July 7, 2022 14:21
@lcnr
Copy link
Contributor Author

lcnr commented Jul 7, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 7, 2022
@bors
Copy link
Contributor

bors commented Jul 7, 2022

⌛ Trying commit f40f608c067f0cbb1ffd0d2d284da302119ac96a with merge 3c6f387d68a4200acd27290e70f49c68ac4ddd62...

@lcnr
Copy link
Contributor Author

lcnr commented Jul 8, 2022 •
edited
Loading

@rust-timer build 3c6f387d68a4200acd27290e70f49c68ac4ddd62

@rust-timer
Copy link
Collaborator

Queued 3c6f387d68a4200acd27290e70f49c68ac4ddd62 with parent c461f7a, future comparison URL.

@lcnr
Copy link
Contributor Author

lcnr commented Jul 8, 2022

the last commit is relevant for perf again

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Contributor

bors commented Jul 8, 2022

⌛ Trying commit 6fb4b0449f4b3038cf978017f088a3e9e6532814 with merge 5f8f3a7067fe8e90fa3b126f966aa67f7c180e60...

@bors
Copy link
Contributor

bors commented Jul 8, 2022

☀️ Try build successful - checks-actions
Build commit: 5f8f3a7067fe8e90fa3b126f966aa67f7c180e60 (5f8f3a7067fe8e90fa3b126f966aa67f7c180e60)

@lcnr
Copy link
Contributor Author

lcnr commented Jul 8, 2022

@rust-timer build 5f8f3a7067fe8e90fa3b126f966aa67f7c180e60

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3c6f387d68a4200acd27290e70f49c68ac4ddd62): comparison url.

Instruction count

  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 0.6% 0.6% 2
Improvements 🎉
(primary)		 -0.5% -0.7% 11
Improvements 🎉
(secondary)		 -0.4% -0.6% 11
All 😿🎉 (primary) -0.5% -0.7% 11

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 😿 relevant regression found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 1.5% 1.5% 1
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) N/A N/A 0

Cycles

Results
  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)		 5.4% 8.7% 2
Regressions 😿
(secondary)		 2.8% 2.8% 2
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) 5.4% 8.7% 2

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 8, 2022
@lcnr
Copy link
Contributor Author

lcnr commented Jul 8, 2022

@rust-timer build 5f8f3a7067fe8e90fa3b126f966aa67f7c180e60

@rust-timer
Copy link
Collaborator

Queued 5f8f3a7067fe8e90fa3b126f966aa67f7c180e60 with parent eba361a, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5f8f3a7067fe8e90fa3b126f966aa67f7c180e60): comparison url.

Instruction count

  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 0.6% 0.7% 6
Improvements 🎉
(primary)		 -0.6% -0.8% 14
Improvements 🎉
(secondary)		 -1.0% -2.3% 18
All 😿🎉 (primary) -0.6% -0.8% 14

Max RSS (memory usage)

Results
  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)		 0.3% 0.3% 1
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) 0.3% 0.3% 1

Cycles

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -3.2% -3.2% 1
Improvements 🎉
(secondary)		 -3.1% -3.7% 3
All 😿🎉 (primary) -3.2% -3.2% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

@lcnr

This comment was marked as outdated.

Sign in to view
@lcnr lcnr added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 8, 2022
@lcnr
Copy link
Contributor Author

lcnr commented Jul 8, 2022

@rustbot ready

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 8, 2022
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 14, 2022
@bors
Copy link
Contributor

bors commented Jul 15, 2022

☔ The latest upstream changes (presumably #99278) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 15, 2022
@lcnr

This comment was marked as outdated.

Sign in to view
@bors

This comment was marked as outdated.

Sign in to view
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 15, 2022
@lcnr
Copy link
Contributor Author

lcnr commented Jul 15, 2022

@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Jul 15, 2022

📌 Commit 16b2acc has been approved by compiler-errors

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 15, 2022

⌛ Testing commit 16b2acc with merge 23e21bd...

@bors
Copy link
Contributor

bors commented Jul 15, 2022

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 23e21bd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 15, 2022
@bors bors merged commit 23e21bd into rust-lang:master Jul 15, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 15, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (23e21bd): comparison url.

Instruction count

  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -0.6% -0.9% 11
Improvements 🎉
(secondary)		 -0.4% -0.6% 11
All 😿🎉 (primary) -0.6% -0.9% 11

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 3.2% 3.2% 1
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -1.3% -1.3% 1
All 😿🎉 (primary) N/A N/A 0

Cycles

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 😿 relevant regression found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 3.2% 3.2% 1
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) N/A N/A 0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

JohnTitor added a commit to JohnTitor/rust-semverver that referenced this pull request Jul 16, 2022
@JohnTitor
Rustup to rust-lang/rust#99015
8d2148d 
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
JohnTitor added a commit to JohnTitor/rust-semverver that referenced this pull request Jul 16, 2022
@JohnTitor
Rustup to rust-lang/rust#99015
5215d9e 
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
@lcnr lcnr deleted the fn-ctxt-no-more branch July 16, 2022 07:05
@lcnr lcnr mentioned this pull request Jul 16, 2022
Closed
3 tasks
@jruderman jruderman mentioned this pull request Oct 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lcnr @rust-timer @bors @compiler-errors @rust-highfive @rustbot