Skip to content

Move coverage tests from run-make-fulldeps to run-make #99715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 29, 2022
Merged

Move coverage tests from run-make-fulldeps to run-make #99715

merged 3 commits into from
Jul 29, 2022

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Jul 25, 2022

No description provided.

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jul 25, 2022
@rust-highfive
Copy link
Contributor

r? @jyn514

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 25, 2022
@tmiasko
Copy link
Contributor Author

tmiasko commented Jul 25, 2022

@bors try

@bors
Copy link
Collaborator

bors commented Jul 25, 2022

⌛ Trying commit 120b194ecaa144916558ebb4799f31c7c926712e with merge 86d64d1b9d88cefc7a8aa0355653925e45ea5544...

@bors
Copy link
Collaborator

bors commented Jul 25, 2022

☀️ Try build successful - checks-actions
Build commit: 86d64d1b9d88cefc7a8aa0355653925e45ea5544 (86d64d1b9d88cefc7a8aa0355653925e45ea5544)

@jyn514
Copy link
Member

jyn514 commented Jul 25, 2022

@tmiasko try doesn't run tests

@jyn514
Copy link
Member

jyn514 commented Jul 25, 2022

@bors r+ rollup=iffy

@bors
Copy link
Collaborator

bors commented Jul 25, 2022

📌 Commit 120b194ecaa144916558ebb4799f31c7c926712e has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 25, 2022
@jyn514 jyn514 added the A-testsuite Area: The testsuite used to check the correctness of rustc label Jul 25, 2022
@bors
Copy link
Collaborator

bors commented Jul 26, 2022

☔ The latest upstream changes (presumably #99745) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 26, 2022
@tmiasko tmiasko force-pushed the coverage-run-make branch from 120b194 to c366faf Compare July 26, 2022 08:09
@tmiasko
Copy link
Contributor Author

tmiasko commented Jul 26, 2022

@bors r=jyn514 rollup=never

@bors
Copy link
Collaborator

bors commented Jul 26, 2022

📌 Commit c366fafa4d7640794dc26b0c0d1b938078016644 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 26, 2022
@bors
Copy link
Collaborator

bors commented Jul 27, 2022

⌛ Testing commit c366fafa4d7640794dc26b0c0d1b938078016644 with merge dd9b3dd15b1d2f2aa3394e06454e7603a71eb288...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Jul 27, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 27, 2022
@jyn514
Copy link
Member

jyn514 commented Jul 27, 2022

Looks spurious? That error would happen on a corrupted download, and this change doesn't touch the python code at all.

@bors retry

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 27, 2022
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 27, 2022
@bors
Copy link
Collaborator

bors commented Jul 27, 2022

⌛ Testing commit c366fafa4d7640794dc26b0c0d1b938078016644 with merge 869ab0bc805ae933725e479b346dd302d91e2eee...

@bors
Copy link
Collaborator

bors commented Jul 27, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 27, 2022
@tmiasko tmiasko force-pushed the coverage-run-make branch from c366faf to 9e448ee Compare July 27, 2022 22:36
@tmiasko tmiasko force-pushed the coverage-run-make branch from 9e448ee to dbe2efa Compare July 28, 2022 12:35
@rustbot rustbot added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Jul 28, 2022
@tmiasko tmiasko force-pushed the coverage-run-make branch from dbe2efa to 01f4534 Compare July 28, 2022 12:54
@tmiasko
Copy link
Contributor Author

tmiasko commented Jul 28, 2022

Updated bootstrap to build rust-demangler for the host instead of a target when executing run-make tests.

@Mark-Simulacrum
Copy link
Member

@bors r+

This seems OK -- I'd love to see them migrate to compiletest proper, but for now this is already likely an improvement, moving the failure earlier.

@bors
Copy link
Collaborator

bors commented Jul 28, 2022

📌 Commit 01f4534 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2022
@bors
Copy link
Collaborator

bors commented Jul 29, 2022

⌛ Testing commit 01f4534 with merge 9fa62f2...

@bors
Copy link
Collaborator

bors commented Jul 29, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 9fa62f2 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 29, 2022
@bors bors merged commit 9fa62f2 into rust-lang:master Jul 29, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 29, 2022
@tmiasko tmiasko deleted the coverage-run-make branch July 29, 2022 15:40
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9fa62f2): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -2.5% -2.7% 2
All 😿🎉 (primary) N/A N/A 0

Cycles

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: 😿 relevant regression found
mean1 max count2
Regressions 😿
(primary)		 2.4% 2.4% 1
Regressions 😿
(secondary)		 5.5% 5.5% 1
Improvements 🎉
(primary)		 -3.2% -4.0% 2
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) -1.3% -4.0% 3

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

JohnTitor added a commit to JohnTitor/rustc-dev-guide that referenced this pull request Feb 2, 2023
@JohnTitor
Address the change in rust-lang/rust#99715
77038f6 
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
tshepang pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Feb 3, 2023
@JohnTitor @tshepang
Address the change in rust-lang/rust#99715
bf4cdde 
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
Kobzol pushed a commit to Kobzol/rust that referenced this pull request Dec 30, 2024
@JohnTitor @tshepang
Address the change in rust-lang#99715
31e3404 
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
bors pushed a commit to rust-lang-ci/rust that referenced this pull request Jan 2, 2025
@JohnTitor @tshepang
Address the change in rust-lang#99715
e74b266 
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
Kobzol pushed a commit to Kobzol/rustc-dev-guide that referenced this pull request Jan 3, 2025
@JohnTitor @tshepang
Address the change in rust-lang/rust#99715
56c7d9f 
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jyn514 jyn514

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.
8 participants
@tmiasko @rust-highfive @bors @jyn514 @rust-log-analyzer @Mark-Simulacrum @rust-timer @rustbot