Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breakup the building chapter #491

Merged
merged 2 commits into from
Nov 6, 2019
Merged

Breakup the building chapter #491

merged 2 commits into from
Nov 6, 2019
+549 −537

Conversation

mark-i-m
Copy link
Member

@mark-i-m mark-i-m commented Nov 5, 2019

This PR breaks up the giant "How to Build and Run the Compiler" chapter into a few subchapters:

-    - [How to Build and Run the Compiler](./how-to-build-and-run.md)
-        - [Build and Install distribution artifacts](./build-install-distribution-artifacts.md)
-        - [Documenting Compiler](./compiler-documenting.md)
+    - [How to Build and Run the Compiler](./building/how-to-build-and-run.md)
+        - [Suggested Workflows](./building/suggested.md)
+        - [Bootstrapping](./building/bootstrapping.md)
+        - [Distribution artifacts](./building/build-install-distribution-artifacts.md)
+        - [Documenting Compiler](./building/compiler-documenting.md)
+        - [ctags](./building/ctags.md)

JohnTitor
JohnTitor approved these changes Nov 5, 2019
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the content is unchanged, I'm going to approve this.

@mark-i-m
Copy link
Member Author

mark-i-m commented Nov 5, 2019

Yes, I added a few filler/intro sentences, but the content is unchanged

@mark-i-m
Copy link
Member Author

mark-i-m commented Nov 5, 2019

Do you feel it is an improvement?

@JohnTitor
Copy link
Member

I agree with this change since I feel "How to Build and Run the Compiler" chapter is long.

@mark-i-m
Copy link
Member Author

mark-i-m commented Nov 6, 2019

Cool :) Thanks @JohnTitor @amanjeev !

@mark-i-m mark-i-m merged commit 16d7318 into rust-lang:master Nov 6, 2019
@Darksonn Darksonn mentioned this pull request Nov 6, 2019
Merged
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 6, 2019
@JohnTitor
Rollup merge of rust-lang#66162 - Darksonn:master, r=ehuss
4d766a0 
Fix broken link in README

The link to the rustc guide on building and running the compiler is broken. It was broken in [rustc-guide#491](rust-lang/rustc-dev-guide#491).
This was referenced Nov 6, 2019
Merged
Merged
Merged
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 7, 2019
@JohnTitor
Rollup merge of rust-lang#66162 - Darksonn:master, r=ehuss
02de841 
Fix broken link in README

The link to the rustc guide on building and running the compiler is broken. It was broken in [rustc-guide#491](rust-lang/rustc-dev-guide#491).
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 7, 2019
@JohnTitor
Rollup merge of rust-lang#66171 - JohnTitor:update-link, r=ehuss
b59d166 
Update link on CONTRIBUTING.md

This is a lost article of rust-lang#66162
Follow-up for rust-lang/rustc-dev-guide#491

CC: @mark-i-m
@mark-i-m mark-i-m deleted the split-building branch March 7, 2020 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mark-i-m @JohnTitor