Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link on CONTRIBUTING.md #66171

Merged
merged 2 commits into from
Nov 7, 2019
Merged

Update link on CONTRIBUTING.md #66171

merged 2 commits into from
Nov 7, 2019

Conversation

JohnTitor
Copy link
Member

This is a lost article of #66162
Follow-up for rust-lang/rustc-dev-guide#491

CC: @mark-i-m

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 6, 2019
@ehuss
Copy link
Contributor

ehuss commented Nov 6, 2019

Oh, sorry, I should have searched for other instances before approving.

Maybe also update the link in librustc/infer/region_constraints/README.md?

@JohnTitor
Copy link
Member Author

Indeed, updated the link

r? @ehuss

@rust-highfive rust-highfive assigned ehuss and unassigned nikomatsakis Nov 6, 2019
@ehuss
Copy link
Contributor

ehuss commented Nov 6, 2019

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 6, 2019

📌 Commit 90b094a has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2019
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 7, 2019
Update link on CONTRIBUTING.md

This is a lost article of rust-lang#66162
Follow-up for rust-lang/rustc-dev-guide#491

CC: @mark-i-m
bors added a commit that referenced this pull request Nov 7, 2019
Rollup of 12 pull requests

Successful merges:

 - #65794 (gate rustc_on_unimplemented under rustc_attrs)
 - #65945 (Optimize long-linker-command-line test)
 - #66044 (Improve uninit/zeroed lint)
 - #66076 (HIR docs: mention how to resolve method paths)
 - #66084 (Do not require extra LLVM backends for `x.py test` to pass)
 - #66111 (improve from_raw_parts docs)
 - #66114 (Improve std::thread::Result documentation)
 - #66117 (Fixed PhantomData markers in Arc and Rc)
 - #66146 (Remove unused parameters in `__thread_local_inner`)
 - #66147 (Miri: Refactor to_scalar_ptr out of existence)
 - #66162 (Fix broken link in README)
 - #66171 (Update link on CONTRIBUTING.md)

Failed merges:

r? @ghost
@bors bors merged commit 90b094a into rust-lang:master Nov 7, 2019
@JohnTitor JohnTitor deleted the update-link branch November 7, 2019 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants