Skip to content

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented Mar 4, 2025

Fix failures in html5ever and piston-image on the beta/stable compiler. The performance change should be minimal:
image

Kobzol added 2 commits March 4, 2025 12:02
Change `RustcEncodable/Decodable` to `serde_json`
Update `num-*` dependencies
@Kobzol Kobzol requested a review from lqd March 4, 2025 11:42
Copy link
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me as well because:

  • one use case is in a build script; another in a dependency (less likely to impact the leaf crate we're benchmarking)
  • the impact is not in the compile times of piston-image
  • we've bumped rustc-serialize in the stable benchmarks before for similar compatibility issues. This time for the RustcDecodable removal, which used to trigger FCW or similar warnings before IIUC.

We could go the opposite way of updating the benchmarks and backfill the data with older rustc releases, if they successfully manage to build these benchmarks, but seeing this PR is not impactful to the actual profiling data, it's simpler to achieve.

@lqd lqd merged commit 70b08b2 into rust-lang:master Mar 4, 2025
11 checks passed
@Kobzol Kobzol deleted the fix-stable-benchmarks branch March 4, 2025 13:02
@Kobzol
Copy link
Member Author

Kobzol commented Mar 4, 2025

We could go the opposite way of updating the benchmarks and backfill the data with older rustc releases, if they successfully manage to build these benchmarks, but seeing this PR is not impactful to the actual profiling data, it's simpler to achieve.

We might need to do that once we update collector HW in the future, but we currently don't have enough tooling for this to make it.. pleasant :)

@lqd
Copy link
Member

lqd commented Mar 4, 2025

Yeah for sure. A good feature request for the new architecture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants