Add total accumulated change to the Aggregations tab #2289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this should be enough, if the set of benchmarks to accumulate can be configured by filters (so we could select only incr-patched benchmarks, for example). Although initially I thought about this being added as one more benchmark in the list (#t-compiler/performance > Average over all benchmarks on the "compare" page @ 💬), but it looks like it's a significantly larger work. |
Yes, the accumulated change will automatically update after filters are modified.
Yeah, that would be more complicated. |
petrochenkov
approved these changes
Oct 20, 2025
Kobzol
force-pushed
the
aggregation-total
branch
from
7442c8d to
ca7d3fc
Compare
Kobzol
force-pushed
the
aggregation-total
branch
from
ca7d3fc to
dd017e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested in https://rust-lang.zulipchat.com/#narrow/channel/247081-t-compiler.2Fperformance/topic/Average.20over.20all.20benchmarks.20on.20the.20.22compare.22.20page/with/545739904.
CC @petrochenkov