Use the new job queue for request duration estimation #2309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
force-pushed
the
queue-estimation
branch
from
32796d4 to
1536009
Compare
Jamesbarford
reviewed
Nov 4, 2025
Contributor
Jamesbarford
left a comment
Jamesbarford
left a comment
There was a problem hiding this comment.
This is ok. However if we need anymore stats we should re-evaluate the merits of dropping this to the SQL layer. As we be able to reduce this complexity.
How many times are we now calling build_queue to display this page?
Member
Author
|
This is called once per queued try build, which happens maybe 5-10 times per day, so I don't think that's a problem. |
Contributor
Sounds good 👍 |
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Kobzol
force-pushed
the
queue-estimation
branch
from
1536009 to
7ab435d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all GH PR comments show that there is nothing in the queue. This PR switches that estimation to the new job queue.