Skip to content

Conversation

@ytmimi
Copy link
Contributor

@ytmimi ytmimi commented Jul 20, 2022

Closes #3164

Show that when error_on_line_overflow=true is set in the rustfmt.toml that an error message is written to stderr.

Closes 3164

Show that when `error_on_line_overflow=true` is set in the rustfmt.toml
that an error message is written to stderr.
@ytmimi
Copy link
Contributor Author

ytmimi commented Jul 20, 2022

The "stable" tests were failing because we couldn't set error_on_line_overflow=true via a rustfmt.toml. I've removed the rustfmt.toml that I was using for testing, and I've updated each test to pass the configuration value via the command line with --config=error_on_line_overflow=true.

@calebcartwright
Copy link
Member

Why the cargo-fmt test? Seems duplicative of the rustfmt test at first blush

@ytmimi
Copy link
Contributor Author

ytmimi commented Jul 21, 2022

The original issue mentioned cargo-fmt, so I figured for completeness I'd add a test where I invoke cargo-fmt

@calebcartwright calebcartwright merged commit c19b145 into rust-lang:master Jul 22, 2022
@calebcartwright
Copy link
Member

The original issue mentioned cargo-fmt, so I figured for completeness I'd add a test where I invoke cargo-fmt

Gotcha, in general unless there's something specific to cargo fmt (as opposed to that just being the user's entry point) there's no need to test something at the rustfmt level through cargo fmt too. However, it's not much extra code so fine here

@ytmimi ytmimi deleted the issue_3164 branch August 7, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

error_on_line_overflow does not diagnose function attributes inside macros

2 participants