rustup-init.sh: Fix unset variable usage#1683
Merged
kinnison merged 1 commit intorust-lang:masterfrom Mar 6, 2019
Merged
Conversation
With `set -u` our check for `RUSTUP_UPDATE_ROOT` being empty needed an additional tweak for it being unset. Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
Contributor
Author
|
As an aside, I'd also like to consider if there's any way we can add to at least one of our travis runs, a verification of the at-least-basic behaviour of |
Contributor
|
Alternatively: #1685. |
dwijnand
approved these changes
Mar 6, 2019
Contributor
|
This is what I was trying to solve in #1604, but it is not received enough attention from reviewer. So I removed that fix and forgot to open new PR for this problem. |
Contributor
|
Ah, yes, I see that now. You're right, @lzutao, sorry about that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lesson learned from 1.17.0 - even when Daniel thinks he has checked
rustup-init.shhe probably needs to check it again./cc @alexcrichton - thanks for the catch.
Fixes #1684