build: Use rustc docker for android targets #1930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tesuji
force-pushed
the
update-android-targets
branch
2 times, most recently
from
410ecb8 to
855f01e
Compare
tesuji
force-pushed
the
update-android-targets
branch
from
855f01e to
a2eb0b4
Compare
Contributor
|
☔ The latest upstream changes (presumably #1916) made this pull request unmergeable. Please resolve the merge conflicts. |
tesuji
force-pushed
the
update-android-targets
branch
from
a2eb0b4 to
c85a508
Compare
tesuji
force-pushed
the
update-android-targets
branch
from
c85a508 to
28f00f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two commits here. The first commit doesn't use rustc docker images but handwritten
one. The second one replaces it with rustc docker images. The rationale for the first commit
is to revert to it when we need in the future.
The first commit when I measure have a longer build time than second one. Probably due to
the installation time of android ndk.