fix(list): Match show command's styling #4558
Merged
+97
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Looks like some of the output ordering is non-determinstic which makes testing this more difficult. snapbox has Is there a reason the output hasn't been made deterministic? I think in Cargo, the only time our output is non-deterministic is when dealing with threads. |
|
@epage I think we might have some sort of misunderstanding here; it's not the output being nondeterministic, rather it's the output being platform-dependent. While we redact the host triple (which will of course be platform-dependent), the output is still strictly in alphanumerical order. Can we, say, sort the redacted output before sending it to comparison? |
This changes the parenthetical from `bold` to `CONTEXT` to match what was done in rust-lang#4556. This does not remove the bolding of the item itself. We could do that. I figured its fine for now since there is a clearer meaning with `installed` than when you can have `active` and `default` on separate items.
|
Alright, here's hoping that this works |
rami3l
approved these changes
Oct 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the parenthetical from
boldtoCONTEXTto match whatwas done in #4556.
This does not remove the bolding of the item itself.
We could do that. I figured its fine for now since there is a clearer
meaning with
installedthan when you can haveactiveanddefaulton separate items.