[STABLE] Prepare for mdbook 0.5 migration #4613
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the stable-branch version of rust-lang#4612 Because the pull_request checks are building docs from main and stable, the checks fail due to mdbook 0.5 changing and removing some fields. This change should allow the books to work with both 0.4 and 0.5. In particular: - `multilingual` -- This was never used, is optional, and is ignored in 0.4. This is rejected in 0.5. - `curly-quotes` -- This was renamed to `smart-punctuation` a long while ago. Both 0.4 and 0.5 use `smart-punctuation`, and 0.5 has removed the old `curly-quotes`. - `src` -- This isn't needed and is an artifact of an `mdbook init` bug.
Contributor
Author
|
Hm, looks like stable is not in a good space right now 😕 |
Member
|
@ehuss That's because the I think we really need to decouple website releases from the main release... everything is very confusing right now for both us and the users, and some stuff that should've been updated hasn't been modified in months :o |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the stable-branch version of #4612
Because the pull_request checks are building docs from main and stable, the checks fail due to mdbook 0.5 changing and removing some fields. This change should allow the books to work with both 0.4 and 0.5. In particular:
multilingual-- This was never used, is optional, and is ignored in 0.4. This is rejected in 0.5.curly-quotes-- This was renamed tosmart-punctuationa long while ago. Both 0.4 and 0.5 usesmart-punctuation, and 0.5 has removed the oldcurly-quotes.src-- This isn't needed and is an artifact of anmdbook initbug.