CI: Separate intrinsic-test from the other CI tests
#1941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhav-madhusoodanan
force-pushed
the
intrinsic-test-ci-modification
branch
from
b64479f to
0545cbe
Compare
folkertdev
reviewed
Oct 20, 2025
Comment on lines
+263
to
+270
| - tuple: arm-unknown-linux-gnueabihf | ||
| os: ubuntu-latest | ||
| - tuple: armv7-unknown-linux-gnueabihf | ||
| os: ubuntu-latest | ||
| - tuple: aarch64-unknown-linux-gnu | ||
| os: ubuntu-latest | ||
| - tuple: aarch64_be-unknown-linux-gnu | ||
| os: ubuntu-latest |
There was a problem hiding this comment.
I think you should be able to structure these rules like here
To reduce the duplication
| shell: bash | ||
| - run: rustup target add ${{ matrix.target.tuple }} | ||
| shell: bash | ||
| if: matrix.build_std == '' |
There was a problem hiding this comment.
just
Suggested change
| if: matrix.build_std == '' | |
| if: matrix.build_std |
should work I think?
| rustup component add rust-src | ||
| echo "CARGO_UNSTABLE_BUILD_STD=std" >> $GITHUB_ENV | ||
| shell: bash | ||
| if: matrix.build_std != '' |
There was a problem hiding this comment.
Suggested change
| if: matrix.build_std != '' | |
| if: ${{ (matrix.build_std || false) == false }} |
is the best I can think of
Comment on lines
+10
to
+11
| #export RUST_TEST_NOCAPTURE=1 | ||
| #export RUST_TEST_THREADS=1 |
There was a problem hiding this comment.
we are not (currently) running RUST_TEST, so I think this can be removed?
Comment on lines
+46
to
+50
| echo "OBJDUMP=${OBJDUMP}" | ||
| echo "STDARCH_DISABLE_ASSERT_INSTR=${STDARCH_DISABLE_ASSERT_INSTR}" | ||
| echo "STDARCH_TEST_EVERYTHING=${STDARCH_TEST_EVERYTHING}" | ||
| echo "STDARCH_TEST_SKIP_FEATURE=${STDARCH_TEST_SKIP_FEATURE}" | ||
| echo "STDARCH_TEST_SKIP_FUNCTION=${STDARCH_TEST_SKIP_FUNCTION}" |
There was a problem hiding this comment.
I think these are not needed?
Comment on lines
+58
to
+60
| x86_64* | i686*) | ||
| export STDARCH_DISABLE_ASSERT_INSTR=1 | ||
| ;; |
There was a problem hiding this comment.
this can likely wait until the x86 PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.