Enable assert_instr for wasm32 throw #1944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @folkertdev rustbot has assigned @folkertdev. Use |
|
Seems like the rust-version is out of date. |
|
Weird, we use rust nightly. Anyhow, this PR should fix that #1945. For posterity: https://triage.rust-lang.org/gha-logs/rust-lang/stdarch/53631742979?pr=1944 |
|
I reported this issue in rust-lang/rust#148104. The workaround was merged, so if you rebase this branch CI should pass. |
coolreader18
force-pushed
the
enable-wasm-throw-test
branch
from
67a5213 to
75dceb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of
wasmtime37.0 wasmtime supports the exception-handling proposal, which means we can uncomment theassert_instrfor thethrowintrinsic.