Skip to content

correct some #[simd_test] attributes #1956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2025
Merged

correct some #[simd_test] attributes #1956

merged 1 commit into from
Nov 16, 2025

Conversation

@sayantn
Copy link
Contributor

@sayantn sayantn commented Nov 10, 2025

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Nov 10, 2025

r? @folkertdev

rustbot has assigned @folkertdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

folkertdev
folkertdev approved these changes Nov 11, 2025
View reviewed changes
Copy link
Contributor

@folkertdev folkertdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you find these by hand, or in some automated way?

@sayantn
Copy link
Contributor Author

sayantn commented Nov 11, 2025

By hand lol, I think I will verify by modifying stdarch_verify first

folkertdev
folkertdev approved these changes Nov 12, 2025
View reviewed changes
Copy link
Contributor

@folkertdev folkertdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well this looks good to me, so please merge it if you think it's ready, or we can wait if you want to work on that verify change first.

@sayantn
Copy link
Contributor Author

sayantn commented Nov 16, 2025

I have corrected some more (this time I actually confirmed by modifying stdarch-verify, but not adding it to CI, too many edge-cases, manual review is required)

folkertdev
folkertdev approved these changes Nov 16, 2025
View reviewed changes
Copy link
Contributor

@folkertdev folkertdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps something like rust-lang/rust-clippy#13240 could help in the future?

@folkertdev folkertdev added this pull request to the merge queue Nov 16, 2025
Merged via the queue into rust-lang:master with commit 672c67f Nov 16, 2025
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@folkertdev folkertdev folkertdev approved these changes

Assignees

@folkertdev folkertdev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sayantn @rustbot @folkertdev