Skip to content

Conversation

@Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Oct 2, 2024

Copy link
Member

@marcoieni marcoieni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving since it's a simple pr.
If you think this PR should have been approved by the team-repo-admins team instead, please reach out and let's discuss this 👍

@Turbo87
Copy link
Member Author

Turbo87 commented Oct 2, 2024

If you think this PR should have been approved by the team-repo-admins team instead, please reach out and let's discuss this

I don't think that's necessary for this PR

@marcoieni
Copy link
Member

I chatted with JD, the general rule is that infra only merge changes to .rs files, so I'll wait for the team-repo-admins to merge this 👍

@Turbo87
Copy link
Member Author

Turbo87 commented Oct 2, 2024

r? @rust-lang/team-repo-admins 🙏

@Turbo87
Copy link
Member Author

Turbo87 commented Oct 2, 2024

side note: this is a change related to the crates.io repository, which is managed by the crates.io team. why does it need approval from @rust-lang/team-repo-admins? if anything it feels like it would need approval from the @rust-lang/crates-io team instead?

the amount of work, bureaucracy and approvals necessary to get an issue moved is quite staggering...

@Kobzol
Copy link
Member

Kobzol commented Oct 2, 2024

This specific change is very unlikely to really need approval from team-repo-admins, but in general it's quite hard to design a heuristic for this. Therefore, so far the consensus is that (at least TOML) changes need approval from team-repo-admins. I think that it would be great if we could grow that team though..

@marcoieni
Copy link
Member

I think it's worth discussing this in zulip or in a separate GitHub issue 👍

@Turbo87
Copy link
Member Author

Turbo87 commented Oct 4, 2024

@rust-lang/team-repo-admins is anything blocking this from your side? do you need more information? what can I do to speed up this process?

@ChrisDenton
Copy link
Member

I think most/all of the admins are away atm. Nothing has been merged in a week.

@rylev rylev merged commit 8717eda into rust-lang:master Oct 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants