-
Notifications
You must be signed in to change notification settings - Fork 327
crates.io: Enable rustbot
#1568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
marcoieni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving since it's a simple pr.
If you think this PR should have been approved by the team-repo-admins team instead, please reach out and let's discuss this 👍
I don't think that's necessary for this PR |
|
I chatted with JD, the general rule is that infra only merge changes to |
|
r? @rust-lang/team-repo-admins 🙏 |
|
side note: this is a change related to the crates.io repository, which is managed by the crates.io team. why does it need approval from @rust-lang/team-repo-admins? if anything it feels like it would need approval from the @rust-lang/crates-io team instead? the amount of work, bureaucracy and approvals necessary to get an issue moved is quite staggering... |
|
This specific change is very unlikely to really need approval from team-repo-admins, but in general it's quite hard to design a heuristic for this. Therefore, so far the consensus is that (at least TOML) changes need approval from team-repo-admins. I think that it would be great if we could grow that team though.. |
|
I think it's worth discussing this in zulip or in a separate GitHub issue 👍 |
|
@rust-lang/team-repo-admins is anything blocking this from your side? do you need more information? what can I do to speed up this process? |
|
I think most/all of the admins are away atm. Nothing has been merged in a week. |
Related:
triagebotconfig file crates.io#9557r? @rust-lang/infra