- 
                Notifications
    
You must be signed in to change notification settings  - Fork 326
 
Add @NobodyXu and @madsmtm to crate-maintainers team #2030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To remove the `[access.individuals]` key in `cc-rs`, and to make Jiahao show up on the website.
          Dry-run check results | 
    
          
 That looks wrong? CC @alexheretic, it looks like you're not part of the   | 
    
| 
           Thanks Mads! I'll also most likely contributing to cc-ras, very occasionally if jobserver has a bug impacting cc-rs or cc needs a feature from it, I might post a PR there and asks for others to review.  | 
    
          
 I've just started to collaborate on smol_str crate, so to that extent maybe I should be?  | 
    
| 
           I think this is ultimately on @Amanieu (as libs team lead) to approve but I this should be fine since they both are already maintaining a libs crate. I don't think we need a special group just for cc-rs.  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved by parent team co-lead.
Motivation: To make Jiahao show up on the website.
This also removes the
[access.individuals]key forcc-rsas part of #1476.CC @rust-lang/crate-maintainers, this would add @NobodyXu and myself to your team. I would limit my use of these rights to contributions to
cc-rs(which admittedly has been very limited lately), I suspect @NobodyXu would do the same.An alternative would be to create a separate team
@rust-lang/cc, I'd be fine with either.