-
Notifications
You must be signed in to change notification settings - Fork 330
crates.io: Add private Zulip streams #2074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
135ee29 to
dba8cc2
Compare
Dry-run check results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Since this is just importing stuff to toml and not doing major changes to the zulip streams (except probably removing people we forgot to remove), I'm approving and merging even if I'm not a team-repo-admin. We can always revert this PR if necessary.
|
(Trivial enough that I think it makes no difference who approves it 😁) |
|
I removed it from the queue because I asked Tobi to add rust-lang-owner to these streams. Otherwise the sync will fail |
crates.io: Add private Zulip streams
|
Error: |
|
ugh... I don't know why it was created that way, but apparently it's called |
|
I would say, either rename the stream if you have permission or ask someone to do it (probably the mods team?). |
|
I renamed the zulip channel to (consistently) use the lowercase t-*. That should be resolved now ( |
|
Here is the diff that was applied: |
I didn't know
[[zulip-streams]]was a thing until now, but this seems quite useful :)