Skip to content

Conversation

@Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 12, 2025

I didn't know [[zulip-streams]] was a thing until now, but this seems quite useful :)

@Turbo87 Turbo87 force-pushed the crates-io-zulip-streams branch from 135ee29 to dba8cc2 Compare November 12, 2025 10:13
@github-actions
Copy link

Dry-run check results

[WARN  sync_team] sync-team is running in dry mode, no changes will be applied.
[INFO  sync_team] synchronizing github

Copy link
Member

@marcoieni marcoieni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Since this is just importing stuff to toml and not doing major changes to the zulip streams (except probably removing people we forgot to remove), I'm approving and merging even if I'm not a team-repo-admin. We can always revert this PR if necessary.

@marcoieni marcoieni added this pull request to the merge queue Nov 12, 2025
@marcoieni marcoieni removed this pull request from the merge queue due to a manual request Nov 12, 2025
@jieyouxu
Copy link
Member

(Trivial enough that I think it makes no difference who approves it 😁)

@marcoieni
Copy link
Member

I removed it from the queue because I asked Tobi to add rust-lang-owner to these streams. Otherwise the sync will fail

@marcoieni marcoieni added this pull request to the merge queue Nov 12, 2025
github-merge-queue bot pushed a commit that referenced this pull request Nov 12, 2025
crates.io: Add private Zulip streams
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 12, 2025
@marcoieni
Copy link
Member

Error: Id of stream 't-crates-io/moderation' not found. The stream probably doesn't exist and sync-team doesn't support creating it yet. Please create the stream manually and add the rust-lang-owner user to it.

@Turbo87
Copy link
Member Author

Turbo87 commented Nov 12, 2025

ugh... I don't know why it was created that way, but apparently it's called T-crates-io/moderation with a capital T 😅

@marcoieni
Copy link
Member

I would say, either rename the stream if you have permission or ask someone to do it (probably the mods team?).
Or, you can also edit this pr

@jieyouxu
Copy link
Member

I renamed the zulip channel to (consistently) use the lowercase t-*. That should be resolved now (t-crates-io/moderation).

@marcoieni marcoieni added this pull request to the merge queue Nov 12, 2025
Merged via the queue into rust-lang:main with commit 44562a0 Nov 12, 2025
3 checks passed
@marcoieni
Copy link
Member

Here is the diff that was applied:

💻 Stream Membership Diffs:
    📝 Updating stream membership:
      Name: t-crates-io/incident-response
      ID: 346298
      Members:
        ➕ 266526
        ➕ 259697
        − 224872
    📝 Updating stream membership:
      Name: t-crates-io/operations
      ID: 346296
      Members:
        ➕ 266526
        ➕ 259697
        − 224872
    📝 Updating stream membership:
      Name: t-crates-io/private
      ID: 346283
      Members:
        − 217081
        − 219929
        − 459395
        − 527401

@Turbo87 Turbo87 deleted the crates-io-zulip-streams branch November 12, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants