Skip to content

link to relevant part of rustc dev guide in modified submodule warning #2130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025
Merged

link to relevant part of rustc dev guide in modified submodule warning #2130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/handlers/check_commits/modified_submodule.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@ use regex::{Regex, RegexBuilder};

use crate::github::FileDiff;

const SUBMODULE_WARNING_MSG: &str = "Some commits in this PR modify **submodules**.";
const SUBMODULE_WARNING_MSG: &str = "Some commits in this PR modify **submodules**.

If this was not intentional, see [I changed a submodule on accident](https://rustc-dev-guide.rust-lang.org/git.html#i-changed-a-submodule-by-accident) in the rustc dev guide.
";

static SUBPROJECT_COMMIT_RE: LazyLock<Regex> = LazyLock::new(|| {
RegexBuilder::new(r"^\+Subproject commit [a-zA-Z0-9]+$")
Expand Down
Loading