uefi-raw: add Tcpv4 protocol type definitions #1797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
JayKickliter
force-pushed
the
jsk/uefi-raw/add-tcpv4
branch
from
507d349 to
86a97e4
Compare
phip1611
requested changes
Oct 22, 2025
|
The typos CI step should be fixed when you add "ANDed" to |
JayKickliter
force-pushed
the
jsk/uefi-raw/add-tcpv4
branch
from
3a822b6 to
3641ccb
Compare
JayKickliter
force-pushed
the
jsk/uefi-raw/add-tcpv4
branch
from
3641ccb to
95e20c4
Compare
|
|
||
| #[derive(Debug)] | ||
| #[repr(C)] | ||
| pub struct Tcpv4Protocol { |
There was a problem hiding this comment.
nit: match the spec name for this protocol
Suggested change
| pub struct Tcpv4Protocol { | |
| pub struct Tcp4Protocol { |
Same for all the other types like Tcpv4ConnectionState; it should match the name in the spec except for converting to PascalCase.
| /// will return to [`Tcpv4ConnectionState::CLOSED`]. | ||
| pub connect: unsafe extern "efiapi" fn( | ||
| this: *mut Self, | ||
| connection_token: *mut Tcpv4CompletionToken, |
There was a problem hiding this comment.
This should be a ConnectionToken rather than a CompletionToken (even though they are essentially the same type)
|
|
||
| #[derive(Debug)] | ||
| #[repr(C)] | ||
| pub struct Ipv4ModeData { |
There was a problem hiding this comment.
I think this type (and some of the following ones) belong in uefi-raw/src/protocol/network/ip4.rs.
| /// Number of entries in the routing table. | ||
| pub route_count: u32, | ||
| /// Routing table entries. | ||
| pub ip4_route_table: *const Ipv4RouteTable, |
There was a problem hiding this comment.
match spec naming:
Suggested change
| pub ip4_route_table: *const Ipv4RouteTable, | |
| pub route_table: *const Ipv4RouteTable, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR 1 of 2 adding TCP functionality to uefi-rs and is a replacement for #1779. I removed the high-level
ueficrate additions and will open a separate PR for them.Checklist