Skip to content

Conversation

@dpetersen
Copy link
Contributor

As we just discussed in #23. Rather than a big warning in the README about specific versions of the Postgres library which you'd have to remember to manually update, I just made the examples use the reexported library as you suggested.

I removed the use postgres::Client since that wasn't actually getting used in the example and was generating a warning.

@dpetersen
Copy link
Contributor Author

It's weird that cargo test is failing on Circle, since I did run it and it's passing locally. Good to see my superpower of breaking CI still works on a Saturday.

@sfackler
Copy link
Collaborator

sfackler commented Nov 7, 2020

CI is running against 1.40, which I'd guess is too old for that version of subtle. It looks like you should just need to bump that to 1.41.0: https://github.com/dalek-cryptography/subtle/blob/master/.travis.yml#L16

subtle was failing on 1.40, then postgres-protocol was failing on 1.41.
@dpetersen
Copy link
Contributor Author

Ah, that makes since. I installed 1.40.0 locally (rustup is awesome) and replicated the issue, then bumped locally. And immediately got this failure:

error[E0658]: use of unstable library feature 'matches_macro'                                                  
   --> /home/dpetersen/.cargo/registry/src/github.com-1ecc6299db9ec823/postgres-protocol-0.5.3/src/authentication/sasl.rs:333:29                                                                                              
    |                                                                                                          
333 |         self.take_while(|c| matches!(c, '\x21'..='\x2b' | '\x2d'..='\x7e'))                              
    |                             ^^^^^^^                                                                      
    |                                                                                                          
    = note: for more information, see https://github.com/rust-lang/rust/issues/65721                           

Looked that up and it was stabilized in 1.42, so bumped to that and we're green.

@sfackler sfackler merged commit 2157bb7 into rust-postgres:master Nov 8, 2020
@sfackler
Copy link
Collaborator

sfackler commented Nov 8, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants