Skip to content

Remove license headers from source files #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 10, 2025
Merged

Remove license headers from source files #25

merged 2 commits into from
Nov 10, 2025

Conversation

@newpavlov
Copy link
Member

@newpavlov newpavlov commented Nov 10, 2025

The LICENSE files and the license fields are sufficient for license attribution, so license header in source files are arguably redundant for projects without mixed-license code bases.

@newpavlov newpavlov requested a review from dhardy November 10, 2025 17:13
@newpavlov
Copy link
Member Author

newpavlov commented Nov 10, 2025

BTW I think rand_core does not contain any code from the Rust project anymore, so we probably could remove its attribution.

dhardy
dhardy approved these changes Nov 10, 2025
View reviewed changes
Copy link
Member

@dhardy dhardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree on both counts.

@newpavlov newpavlov merged commit 4d22ab2 into master Nov 10, 2025
13 checks passed
@newpavlov newpavlov deleted the rm_headers branch November 10, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhardy dhardy dhardy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@newpavlov @dhardy