-
-
Notifications
You must be signed in to change notification settings - Fork 1
ci: fix release workflow #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| RELEASE_VERSION="${{ github.ref_name.slice }}" | ||
| echo "Version: $RELEASE_VERSION" | ||
| RELEASE_BODY=$(awk -v ver="[${RELEASE_VERSION:1}]" '/^## / { if (p) { exit }; if ($2 == ver) { p=1; next } } p && NF' CHANGELOG.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RELEASE_VERSION will have a v in it, causing awk not to match the result.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, note the :1 part, it removes the first character.
|
I configured crates.io |
|
Now you need to approve the workflow (I added the protection rule to the environment). |
|
I approved the release. It wasn't clear if this is a one-off approval for the workflow or not. The GitHub release failed due to |
|
Hm... Should we change the environment settings somehow? Or is because of UPD: Ah, it seems release creation requires write permissions. |
|
The last run appears to have been successful but doesn't correspond to anything: I guess you deleted the resulting GH release? I think we should probably not make a GH release for pre-releases. (Or if we do want to, we can't use this awk script.) |
|
Yes, I deleted the results.
Good idea. I will try to tweak the config later. |
No description provided.