-
Notifications
You must be signed in to change notification settings - Fork 123
Added cargo audit and deny to test github action and action to push published releases to crates.io #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I also added a crates.io publisher for you as well. Just need to add your crates.io token to secrets (and you might want to run it initially with |
|
I refactored the cargo deny into action as you recommended and reverted the cargo publish workflow. Would you consider this as a change or did you want to just close this PR? Regardless of the outcome would you be able to cut a new release from main if it's ready please? This would unblock my build (and resolve #285). |
|
I think the deny action is useful, but I want to give the other maintainers a change to express their opinions before merging anything.
When using scanning in a CI pipeline, I think one should always be prepared to just acknowledge issues to unblock builds. Again, this is about producing software with known properties, not green checkmarks. And the lack of maintenance of So in this case, I would argue that using |
|
No problem - thanks! Added the unmaintained = workspace to my project. |
|
Since no opinions were expressed so far, let's merge this and revert/amend/modify if something comes up later on. |
|
@cfvescovo I tagged a v0.25.0 release which most importantly bumps the Servo deps. Since I do not have access to crates.io, could you please publish the tag? Thanks! |
|
Sure, I am publishing it now |
Related to #285, added to your tests to check for security vulnerabilities and packages that have advisories on. This should pass for the current master branch.