-
Notifications
You must be signed in to change notification settings - Fork 0
Initial project setup #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Instead of can_tail_file we could tail the file ourselves instead calling tail, but that is a task for a future PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, just found a typo in the long_about
do you also mean to implement all the supported |
The change contains basic command implementation with unittests
|
LGTM! |
The change contains basic implementation of the command with unittests.
Currently, for simplicity, the tail command itself doesn't accept any options, i.e. running it as
tailor -f <filename> <command>is not possible. However, the alternative command accepts as many options as needed, and the filename is passed as the last option there.