Fix potential overflow in FdtWriter::begin_node() #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a check to make sure than node depth does not exceed usize::MAX. Signed-off-by: Sergii Glushchenko <gsserge@amazon.com>
Author
|
I'm using 'if' block instead of |
danielverkamp
previously approved these changes
Oct 18, 2021
Collaborator
danielverkamp
left a comment
danielverkamp
left a comment
There was a problem hiding this comment.
This style of check looks fine to me; thanks for adding the comment explaining it at the addition as well.
Signed-off-by: Sergii Glushchenko <gsserge@amazon.com>
Signed-off-by: Sergii Glushchenko <gsserge@amazon.com>
andreeaflorescu
approved these changes
Oct 19, 2021
lauralt
approved these changes
Oct 19, 2021
| const FDT_HEADER_SIZE: usize = 40; | ||
| const FDT_VERSION: u32 = 17; | ||
| const FDT_LAST_COMP_VERSION: u32 = 16; | ||
| /// The same max depth as in the Linux kernel. |
Contributor
There was a problem hiding this comment.
nit: this should be part of the previous commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check to make sure than node depth does not
exceed
FDT_MAX_NODE_DEPTH.Signed-off-by: Sergii Glushchenko gsserge@amazon.com