Do not send Window to another thread in winit_multithread example
#287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The threading implications of accessing a window from another thread are unclear, so Winit chooses to block on the main thread on macOS and iOS. This means that we have to send the surface width and height to the other thread instead of trying to access it dynamically from the window.
madsmtm
added
documentation
madsmtm
changed the title
Window to another threadWindow to another thread in winit_multithread example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The threading implications of accessing a window from another thread are unclear, so Winit chooses to block on the main thread on macOS and iOS.
This means that we have to send the surface width and height to the other thread instead of trying to access it dynamically from the window.
This fixes #249.