Get rid of cfg_aliases
#294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were used in examples (which they shouldn't, that makes those harder to copy) and in two places in the implementation, which feels like too few for it to be worth it. They also can't be used in Cargo.toml, so we are forced to have at least _some_ duplication.
MarijnS95
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were used in examples (which they shouldn't, that makes those harder to copy) and in two places in the implementation, which feels like too few for it to be worth it. They also can't be used in
Cargo.toml, so we are forced to have at least some duplication.The main motivation is that it allows us to avoid having a build script, which is nice for compile-times.